Merge lp:~mwhudson/livecd-rootfs/live-server-set-refresh.hold into lp:livecd-rootfs

Proposed by Michael Hudson-Doyle on 2018-03-21
Status: Rejected
Rejected by: Michael Hudson-Doyle on 2018-03-22
Proposed branch: lp:~mwhudson/livecd-rootfs/live-server-set-refresh.hold
Merge into: lp:livecd-rootfs
Diff against target: 26 lines (+8/-0)
2 files modified
debian/changelog (+7/-0)
live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/snap.subiquity.subiquity-service.service.d/subiquity.conf (+1/-0)
To merge this branch: bzr merge lp:~mwhudson/livecd-rootfs/live-server-set-refresh.hold
Reviewer Review Type Date Requested Status
Ubuntu Core Development Team 2018-03-21 Pending
Review via email: mp+341801@code.launchpad.net

Description of the change

This is the suggestion I got from #snappy. Not tested yet, will do so tomorrow probably.

To post a comment you must log in.
Michael Hudson-Doyle (mwhudson) wrote :

Oh, this is easier to test than I feared. It works :)

BTW, you can set refresh.hold more than 60 days in the future but snapd will refresh every 60 days anyway so there's no point.

Michael Hudson-Doyle (mwhudson) wrote :

BTW https://bugs.launchpad.net/snapd/+bug/1723094 has a more general solution attached to it in a patch so anyone who reviews this should maybe review that first.

Michael Hudson-Doyle (mwhudson) wrote :

The casper fix got merged so this isn't necessary any more.

Unmerged revisions

1646. By Michael Hudson-Doyle on 2018-03-21

Prevent snap refreshes from happening in the live-server session (well for
60 days...)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2018-03-21 02:58:05 +0000
3+++ debian/changelog 2018-03-21 08:18:16 +0000
4@@ -1,3 +1,10 @@
5+livecd-rootfs (2.514) UNRELEASED; urgency=medium
6+
7+ * Prevent snap refreshes from happening in the live-server session (well for
8+ 60 days...)
9+
10+ -- Michael Hudson-Doyle <michael.hudson@ubuntu.com> Wed, 21 Mar 2018 21:15:37 +1300
11+
12 livecd-rootfs (2.513) bionic; urgency=medium
13
14 * In the live-server build, prevent casper from mounting any existing
15
16=== modified file 'live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/snap.subiquity.subiquity-service.service.d/subiquity.conf'
17--- live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/snap.subiquity.subiquity-service.service.d/subiquity.conf 2018-03-15 00:22:22 +0000
18+++ live-build/ubuntu-server/includes.binary/overlay/lib/systemd/system/snap.subiquity.subiquity-service.service.d/subiquity.conf 2018-03-21 08:18:16 +0000
19@@ -4,6 +4,7 @@
20 ConditionPathExists=!/run/subiquity/complete
21
22 [Service]
23+ExecStartPre=/bin/sh -c "snap set core refresh.hold=$(date --date=now+60days --iso-8601=seconds)"
24 Environment=SNAP_REEXEC=0
25 UtmpIdentifier=tty1
26 TTYPath=/dev/tty1

Subscribers

People subscribed via source and target branches