Merge lp:~mwhudson/lava-scheduler/more-helpful-401s-bug-917390 into lp:lava-scheduler

[Michael Hudson-Doyle]

This changes the permission errors produced by submit_job a bit. They now look like this:

$ lava-tool submit-job http://locallava/RPC2/ ~/canonical/repos/lava-dispatcher/lava-ltp-job-justtest
EXPERIMENTAL - SUBJECT TO CHANGE (See --experimental-notice for more info)
ERROR: <Fault 401: 'Authentication with user and token required for this API.'>

$ lava-tool submit-job http://test@locallava/RPC2/ ~/canonical/repos/lava-dispatcher/lava-ltp-job-justtest
EXPERIMENTAL - SUBJECT TO CHANGE (See --experimental-notice for more info)
ERROR: <Fault 403: "Permission denied. User u'test' does not have the 'lava_scheduler_app.add_testjob' permission. Contact administrators to fix this.">

Let me know what you think (I think we could possibly try to display the errors a little better, but that's a client side thing).

[Zygmunt Krynicki (zyga)]

+1

review: Approve

=== modified file 'lava_scheduler_app/api.py'
--- lava_scheduler_app/api.py	2011-10-19 21:05:42 +0000
+++ lava_scheduler_app/api.py	2012-01-25 03:00:33 +0000
@@ -16,9 +16,14 @@
 
     def submit_job(self, job_data):
         if not self.user:
-            raise xmlrpclib.Fault(401, "Authentication required.")
+            raise xmlrpclib.Fault(
+                401, "Authentication with user and token required for this "
+                "API.")
         if not self.user.has_perm('lava_scheduler_app.add_testjob'):
-            raise xmlrpclib.Fault(403, "Permission denied.")
+            raise xmlrpclib.Fault(
+                403, "Permission denied.  User %r does not have the "
+                "'lava_scheduler_app.add_testjob' permission.  Contact "
+                "the administrators." % self.user.username)
         try:
             job = TestJob.from_json_and_user(job_data, self.user)
         except JSONDecodeError as e: