LAVA Scheduler (deprecated)

Merge lp:~mwhudson/lava-scheduler/binary-goop-in-job-file-bug-918954 into lp:lava-scheduler

  1. binary-goop-in-job-file-bug-918954
  2. Merge into trunk
Proposed by Michael Hudson-Doyle
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 117
Merged at revision: 117
Proposed branch: lp:~mwhudson/lava-scheduler/binary-goop-in-job-file-bug-918954
Merge into: lp:lava-scheduler
Diff against target: 11 lines (+1/-0)
1 file modified
lava_scheduler_app/logfile_helper.py (+1/-0)
To merge this branch: bzr merge lp:~mwhudson/lava-scheduler/binary-goop-in-job-file-bug-918954
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+89377@code.launchpad.net

Description of the change

Fortunately the fix for the linked bug turned out to be simple. You can verify the fix by looking at the log_file for job 8582, if you have a production snapshot lying around.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Looks good, eventually we'll want to handle binary goops a bit better. The reason they are there are two fold:

1) We get genuine trash over the serial line
2) We see terminal command codes

I have a skunk project to use the latter better (related to lava-serial)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lava_scheduler_app/logfile_helper.py'
2--- lava_scheduler_app/logfile_helper.py 2012-01-11 22:09:33 +0000
3+++ lava_scheduler_app/logfile_helper.py 2012-01-20 04:22:24 +0000
4@@ -52,6 +52,7 @@
5
6 for line in logfile:
7 line = line.replace('\r', '')
8+ line = unicode(line, 'ascii', 'replace')
9 if not line:
10 continue
11 if line == 'Traceback (most recent call last):\n':

Subscribers

People subscribed via source and target branches