Code review comment for lp:~mwhudson/lava-kernel-ci-views/add-board-type-model

On Tue, 24 Jan 2012 22:45:28 -0000, Paul Larson <email address hidden> wrote:
> Review: Approve
>
> Looks good to me, just a couple of comments. But nothing that I see as a blocker.
> The image/board link seems a bit amorphous to me. Perhaps if we
> restricted the size of the logo? Or maybe put a border around it?
> It's something that I think we could improve on visually a bit, but
> it's not bad how it is. We just need to make sure to solicit good
> icons from everyone that *they* are happy with.

Yeah, if we can get everyone to send us icons that are the same height
(ideally about 100px) and roughly square, that would be great.

> Also, on the compile status view, we will still have multiple builds
> with the same defconfig. We now know that these are really the same
> thing getting built, but are destined to be run on different boards.
> Metadata to help us determine that is now included, and we may want to
> consider referencing that somewhere. This has been raised before as
> something that users find confusing.

Yeah. I was thinking it wouldn't be too hard to suppress duplicate
results -- if they both built the same defconfig and had the same
outcome, just displaying one should be enough. (if they had a different
outcome, something pretty bizarre is going on).

Cheers,
mwh