Merge lp:~mwhudson/lava-android-test/add-setup.cfg-workaround-bug-988710 into lp:lava-android-test

Proposed by Michael Hudson-Doyle
Status: Merged
Merged at revision: 152
Proposed branch: lp:~mwhudson/lava-android-test/add-setup.cfg-workaround-bug-988710
Merge into: lp:lava-android-test
Diff against target: 6 lines (+2/-0)
1 file modified
setup.cfg (+2/-0)
To merge this branch: bzr merge lp:~mwhudson/lava-android-test/add-setup.cfg-workaround-bug-988710
Reviewer Review Type Date Requested Status
Yongqin Liu Approve
Review via email: mp+104051@code.launchpad.net

Description of the change

Please see the comments on the linked bug report for why this helps.

To post a comment you must log in.
Revision history for this message
Yongqin Liu (liuyq0307) wrote :

I don't if it's right. but I believe that it is right:)

BTW, before we merge it to trunk, how can I verify that the problem has been resolved?

review: Approve
Revision history for this message
Andy Doan (doanac) wrote :

On 05/09/2012 01:37 AM, Yongqin Liu wrote:
> I don't if it's right. but I believe that it is right:)

Best review comment I've ever read! :)

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

On Wed, 09 May 2012 06:37:17 -0000, Yongqin Liu <email address hidden> wrote:
> Review: Approve
>
> I don't if it's right. but I believe that it is right:)
>
> BTW, before we merge it to trunk, how can I verify that the problem has been resolved?

I think the way to check is this: before, when you run "python setup.py
sdist" you get a tarball that contains setup.cfg but the
lava_android_test.egg-info/SOURCES.txt file in the tarball does not list
setup.cfg. After, SOURCES.txt lists setup.cfg.

Cheers,
mwh

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

> On Wed, 09 May 2012 06:37:17 -0000, Yongqin Liu <email address hidden>
> wrote:
> > Review: Approve
> >
> > I don't if it's right. but I believe that it is right:)
> >
> > BTW, before we merge it to trunk, how can I verify that the problem has been
> resolved?
>
> I think the way to check is this: before, when you run "python setup.py
> sdist" you get a tarball that contains setup.cfg but the
> lava_android_test.egg-info/SOURCES.txt file in the tarball does not list
> setup.cfg. After, SOURCES.txt lists setup.cfg.
>
By this way, it's right:)
Merge first.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'setup.cfg'
2--- setup.cfg 1970-01-01 00:00:00 +0000
3+++ setup.cfg 2012-04-29 23:54:17 +0000
4@@ -0,0 +1,2 @@
5+[upload]
6+sign=True

Subscribers

People subscribed via source and target branches