Launchpad itself

Merge lp:~mwhudson/launchpad/git-http-imports-bug-438929 into lp:launchpad

  1. git-http-imports-bug-438929
  2. Merge into devel
Proposed by Michael Hudson-Doyle on 2010-03-05
Status: Merged
Approved by: Tim Penhey on 2010-03-05
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~mwhudson/launchpad/git-http-imports-bug-438929
Merge into: lp:launchpad
Diff against target: 12 lines (+1/-1)
1 file modified
lib/lp/code/browser/codeimport.py (+1/-1)
To merge this branch: bzr merge lp:~mwhudson/launchpad/git-http-imports-bug-438929
Reviewer Review Type Date Requested Status
Tim Penhey (community) 2010-03-05 Approve on 2010-03-05
Review via email: mp+20716@code.launchpad.net

Commit Message

Allow the creation of http git imports.

Description of the Change

Hi,

bzr-git and dulwich now support http urls for git imports, so we should allow people to create such imports.

No tests, but I tested locally and it works.

Cheers,
mwh

To post a comment you must log in.
Tim Penhey (thumper) wrote :

Good enough for me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/code/browser/codeimport.py'
2--- lib/lp/code/browser/codeimport.py 2010-01-20 03:19:44 +0000
3+++ lib/lp/code/browser/codeimport.py 2010-03-07 20:23:27 +0000
4@@ -216,7 +216,7 @@
5 description=_(
6 "The URL of the git repository. The HEAD branch will be "
7 "imported."),
8- allowed_schemes=["git"],
9+ allowed_schemes=["git", "http", "https"],
10 allow_userinfo=False, # Only anonymous access is supported.
11 allow_port=True,
12 allow_query=False,