Merge lp:~mwhudson/launchpad/feature-flag-xmlrpc-2 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Robert Collins | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 14068 | ||||
Proposed branch: | lp:~mwhudson/launchpad/feature-flag-xmlrpc-2 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
569 lines (+268/-39) 13 files modified
configs/development/launchpad-lazr.conf (+1/-0) lib/canonical/config/schema-lazr.conf (+6/-0) lib/canonical/launchpad/interfaces/launchpad.py (+2/-0) lib/canonical/launchpad/xmlrpc/application.py (+6/-1) lib/lp/services/features/__init__.py (+12/-0) lib/lp/services/features/configure.zcml (+7/-0) lib/lp/services/features/scopes.py (+61/-26) lib/lp/services/features/tests/test_scopes.py (+5/-3) lib/lp/services/features/tests/test_webapp.py (+5/-5) lib/lp/services/features/tests/test_xmlrpc.py (+99/-0) lib/lp/services/features/xmlrpc.py (+59/-0) lib/lp/testing/factory.py (+2/-2) utilities/page-performance-report.ini (+3/-2) |
||||
To merge this branch: | bzr merge lp:~mwhudson/launchpad/feature-flag-xmlrpc-2 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Collins (community) | Approve | ||
Review via email: mp+76493@code.launchpad.net |
Commit message
[r=lifeless][bug=853635] Add a private XML-RPC interface to query feature flags
Description of the change
This relands my branch https:/
The change that fixes the problem is here: http://
I haven't added an integration level test, because it would be a lot of work I think (you could register a view with a template that accesses a feature flag and then use testbrowser to load it) and I'm not sure it would have caught this problem anyway (are you really sure that the way testbrowser does authentication is that similar to how it happens in a real appserver? maybe it is, but I don't know). I can add one if the reviewer thinks it's a good idea though.
Thanks.