Merge lp:~mwhudson/launchpad/back-off-failing-imports-bug-413637 into lp:launchpad
Proposed by
Michael Hudson-Doyle
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Michael Hudson-Doyle | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~mwhudson/launchpad/back-off-failing-imports-bug-413637 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
176 lines (+64/-24) 3 files modified
lib/lp/code/interfaces/codeimportjob.py (+12/-3) lib/lp/code/model/codeimportjob.py (+27/-21) lib/lp/code/model/tests/test_codeimportjob.py (+25/-0) |
||||
To merge this branch: | bzr merge lp:~mwhudson/launchpad/back-off-failing-imports-bug-413637 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Penhey (community) | Approve | ||
Review via email: mp+21411@code.launchpad.net |
Commit message
Exponentially back off trying failing code imports before marking them failed.
Description of the change
This is a re-propose of https:/
Hi there,
This small branch changes the code import system to exponentially back off on retrying code imports -- see the linked bug for more.
Currently it backs off so that it tries imports at 6, 12, 24 and 48 hours (for subversion) for a total of three and a bit days of trying before marking an import failed -- is that enough? It seems OK, though perhaps a bit on the low side, to me.
Cheers,
mwh
To post a comment you must log in.
> def newJob(code_import, interval= datetime. timedelta( 0)):
Shouldn't we default the interval to None? Having objects as default args just makes me feel funny.
Actually you do use interval=None in the model class. Can you update the interface to match please?