Merge lp:~mwhudson/juju-core/gccgo-reflection-fun into lp:~go-bot/juju-core/trunk
Proposed by
John A Meinel
Status: | Rejected |
---|---|
Rejected by: | John A Meinel |
Proposed branch: | lp:~mwhudson/juju-core/gccgo-reflection-fun |
Merge into: | lp:~go-bot/juju-core/trunk |
Diff against target: |
128 lines (+33/-7) 4 files modified
rpc/reflect_test.go (+3/-0) rpc/rpc_test.go (+15/-4) rpc/rpcreflect/type.go (+12/-2) state/apiserver/root.go (+3/-1) |
To merge this branch: | bzr merge lp:~mwhudson/juju-core/gccgo-reflection-fun |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
John A Meinel | Approve | ||
Review via email: mp+195717@code.launchpad.net |
Commit message
Change RPC methods to not return empty structs.
Empty structs cause gccgo to panic, so instead we use struct { _ bool } to ensure they are not empty.
Description of the change
This fixes the linked bug and makes attempting to return a structure fail. I expect this will confusingly break other parts of Juju...
To post a comment you must log in.
Unmerged revisions
- 2076. By Michael Hudson-Doyle
-
another workaround field
- 2075. By Michael Hudson-Doyle
-
add workaround fields
- 2074. By Michael Hudson-Doyle
-
discard methods taking or returning empty structures
Resubmitting seems to have sorted Launchpad out. Now on to review.