Merge lp:~mwhudson/debian-cd/live-server-cmdline-2 into lp:~ubuntu-cdimage/debian-cd/ubun3

Proposed by Michael Hudson-Doyle
Status: Merged
Merged at revision: 1986
Proposed branch: lp:~mwhudson/debian-cd/live-server-cmdline-2
Merge into: lp:~ubuntu-cdimage/debian-cd/ubun3
Diff against target: 66 lines (+11/-7)
1 file modified
tools/boot/bionic/boot-amd64 (+11/-7)
To merge this branch: bzr merge lp:~mwhudson/debian-cd/live-server-cmdline-2
Reviewer Review Type Date Requested Status
Steve Langasek Approve
Review via email: mp+336177@code.launchpad.net

Description of the change

changes to live-server default kernel command line

To post a comment you must log in.
1985. By Michael Hudson-Doyle

leave quiet at default for live-server

Revision history for this message
Steve Langasek (vorlon) :
review: Approve
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

This is merged but does not seem to have taken effect. Is there another deployment step required or did I mess something up?

Revision history for this message
Steve Langasek (vorlon) wrote :

On Sun, Mar 11, 2018 at 11:43:05PM -0000, Michael Hudson-Doyle wrote:

> This is merged but does not seem to have taken effect. Is there another
> deployment step required or did I mess something up?

Another deployment step. Sorry, deployed now.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tools/boot/bionic/boot-amd64'
2--- tools/boot/bionic/boot-amd64 2017-11-29 19:40:53 +0000
3+++ tools/boot/bionic/boot-amd64 2018-02-12 21:18:56 +0000
4@@ -417,12 +417,16 @@
5 append normal=
6 EOF
7 if [ "$CDIMAGE_LIVE" = 1 ]; then
8+ QUIET=quiet
9+ SPLASH=splash
10 if [ "$PROJECT" = kubuntu ] || [ "$PROJECT" = kubuntu-plasma5 ]; then
11 livelabel="^Start $HUMANPROJECT"
12 liveparams=' maybe-ubiquity'
13 elif [ "$PROJECT" = ubuntu-server ]; then
14 livelabel="^Install $HUMANPROJECT"
15- liveparams=' union=aufs'
16+ liveparams=' union=overlay'
17+ DEFAULT_PRESEED=
18+ SPLASH=
19 else
20 livelabel="^Try $HUMANPROJECT without installing"
21 liveparams=
22@@ -431,19 +435,19 @@
23 label live
24 menu label $livelabel
25 kernel $CASPER_KERNEL
26- append $KERNEL_PARAMS $DEFAULT_PRESEED boot=casper$liveparams initrd=$CASPER_INITRD quiet splash ---
27+ append $KERNEL_PARAMS $DEFAULT_PRESEED boot=casper$liveparams initrd=$CASPER_INITRD $QUIET $SPLASH ---
28 EOF
29 cat >> $CDDIR/boot/grub/grub.cfg <<EOF
30 menuentry "${livelabel#^}" {
31 set gfxpayload=keep
32- linux $CASPER_KERNEL $KERNEL_PARAMS $DEFAULT_PRESEED boot=casper$liveparams quiet splash ---
33+ linux $CASPER_KERNEL $KERNEL_PARAMS $DEFAULT_PRESEED boot=casper$liveparams $QUIET $SPLASH ---
34 initrd $CASPER_INITRD
35 }
36 EOF
37 cat >> $CDDIR/boot/grub/loopback.cfg <<EOF
38 menuentry "${livelabel#^}" {
39 set gfxpayload=keep
40- linux $CASPER_KERNEL $KERNEL_PARAMS $DEFAULT_PRESEED boot=casper$liveparams iso-scan/filename=\${iso_path} quiet splash ---
41+ linux $CASPER_KERNEL $KERNEL_PARAMS $DEFAULT_PRESEED boot=casper$liveparams iso-scan/filename=\${iso_path} $QUIET $SPLASH ---
42 initrd $CASPER_INITRD
43 }
44 EOF
45@@ -452,18 +456,18 @@
46 label live-install
47 menu label ^Install $HUMANPROJECT
48 kernel $CASPER_KERNEL
49- append $KERNEL_PARAMS $DEFAULT_PRESEED boot=casper only-ubiquity initrd=$CASPER_INITRD quiet splash ---
50+ append $KERNEL_PARAMS $DEFAULT_PRESEED boot=casper only-ubiquity initrd=$CASPER_INITRD $QUIET $SPLASH ---
51 EOF
52 cat >> $CDDIR/boot/grub/grub.cfg <<EOF
53 menuentry "Install $HUMANPROJECT" {
54 set gfxpayload=keep
55- linux $CASPER_KERNEL $KERNEL_PARAMS $DEFAULT_PRESEED boot=casper only-ubiquity quiet splash ---
56+ linux $CASPER_KERNEL $KERNEL_PARAMS $DEFAULT_PRESEED boot=casper only-ubiquity $QUIET $SPLASH ---
57 initrd $CASPER_INITRD
58 }
59 EOF
60 cat >> $CDDIR/boot/grub/loopback.cfg <<EOF
61 menuentry "Install $HUMANPROJECT" {
62- linux $CASPER_KERNEL $KERNEL_PARAMS $DEFAULT_PRESEED boot=casper only-ubiquity iso-scan/filename=\${iso_path} quiet splash ---
63+ linux $CASPER_KERNEL $KERNEL_PARAMS $DEFAULT_PRESEED boot=casper only-ubiquity iso-scan/filename=\${iso_path} $QUIET $SPLASH ---
64 initrd $CASPER_INITRD
65 }
66 EOF

Subscribers

People subscribed via source and target branches