Merge lp:~mwhudson/debian-cd/half-the-grubs into lp:~ubuntu-cdimage/debian-cd/ubun3
Status: | Merged |
---|---|
Merged at revision: | 2080 |
Proposed branch: | lp:~mwhudson/debian-cd/half-the-grubs |
Merge into: | lp:~ubuntu-cdimage/debian-cd/ubun3 |
Prerequisite: | lp:~mwhudson/debian-cd/document-xorriso-options |
Diff against target: |
70 lines (+22/-25) 1 file modified
tools/boot/groovy/boot-amd64 (+22/-25) |
To merge this branch: | bzr merge lp:~mwhudson/debian-cd/half-the-grubs |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Langasek | 2020-07-08 | Approve on 2020-09-10 | |
Paride Legovini (community) | Needs Fixing on 2020-09-03 | ||
Review via email:
|
Description of the change
go back to two copies of grub on the ISO, not four
Staring hard at the previous command line and some experimentation got me there
in the end. Read the comments for more explanation.
Michael Hudson-Doyle (mwhudson) wrote : | # |
Paride Legovini (paride) wrote : | # |
Two inline comments, of which one I think it's an actual thing to fix.
Paride Legovini (paride) wrote : | # |
The static validation of the Groovy images is currently failing because UTAH is unable to find the EFI files, but the images themselves work. I'd prefer to see this MP land before working on UTAH to avoid fixing it twice :)
The ISO testing jobs are currently only testing the images booting them in cdrom mode (both bios and uefi). I'd like to add jobs to also test the "boot as disk" path at some point, as that's certainly the most common scenario nowadays.
- 2082. By Michael Hudson-Doyle on 2020-09-10
-
review feedback
Michael Hudson-Doyle (mwhudson) wrote : | # |
Thanks for the review! I'd like this to land soon too :/
Steve Langasek (vorlon) wrote : | # |
We'll have to subject this to testing to figure out in the end if it's correct.
ping