Code review comment for lp:~mwhudson/debian-cd/document-xorriso-options

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Thanks for looking at this!!

> The only difference I can see with the original command is that the
>
> -eltorito-alt-boot -e boot/grub/efi.img -no-emul-boot
>
> options block and the
>
> -append_partition 2 0xef cd-boot-images/usr/share/cd-boot-images-
> amd64/tree/boot/grub/efi.img
>
> options block are swapped. I imagine you did it on purpose to add the boot
> options in a logical order:
>
> - Legacy cdrom
> - Legacy disk
> - UEFI cdrom
> - UEFI disk

Right.

> I don't see a reason why the new options order shouldn't work, but I didn't
> test it.

I think I tested this at the time...

> Added another inline comment.

Thanks, fixed this and the other one.

« Back to merge proposal