Merge ~mwhudson/debian-cd/+git/ubuntu:no-source-isos into ~ubuntu-cdimage/debian-cd/+git/ubuntu:main

Proposed by Michael Hudson-Doyle
Status: Merged
Merged at revision: 398472c0da6ba292299f4998db91344e6438938b
Proposed branch: ~mwhudson/debian-cd/+git/ubuntu:no-source-isos
Merge into: ~ubuntu-cdimage/debian-cd/+git/ubuntu:main
Diff against target: 340 lines (+3/-268)
3 files modified
Makefile (+0/-17)
build_all.sh (+3/-4)
dev/null (+0/-247)
Reviewer Review Type Date Requested Status
Steve Langasek Approve
Review via email: mp+459682@code.launchpad.net

Description of the change

remove most code to do with making source ISOs

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

looks like there are still some references to 'src' and 'source' here that ought to be cleaned up as part of this merge.

$ grep -li src * 2>/dev/null
Makefile
README
$

review: Needs Fixing
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Yes fair. I took a rather extreme approach for the README, hope that's ok.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

So my initial commit got merged despite the needs fixing review? In any case I've just updated this to remove some more references.

Revision history for this message
Steve Langasek (vorlon) wrote :

On Sun, Feb 11, 2024 at 08:35:58PM -0000, Michael Hudson-Doyle wrote:

> So my initial commit got merged despite the needs fixing review? In any
> case I've just updated this to remove some more references.

Oops! Terrible local review workflow, sorry.

I'll follow through on this now

Revision history for this message
Steve Langasek (vorlon) wrote :

Yes fair. I took a rather extreme approach for the README, hope that's ok.

> --- a/README
> +++ /dev/null

lol ok fair

Revision history for this message
Steve Langasek (vorlon) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Makefile b/Makefile
2index e8bc4b3..021bb6c 100644
3--- a/Makefile
4+++ b/Makefile
5@@ -48,16 +48,10 @@ endif
6 ifndef BINDISKINFO
7 export BINDISKINFO="$(CAPPROJECT)$(CAPSUBPROJECT) $(DEBVERSION) \"$(CAPCODENAME)\" - $(OFFICIAL) $(FULLARCH) ($$DATE)"
8 endif
9-ifndef SRCDISKINFO
10-export SRCDISKINFO="$(CAPPROJECT)$(CAPSUBPROJECT) $(DEBVERSION) \"$(CAPCODENAME)\" - $(OFFICIAL) Source-$$num ($$DATE)"
11-endif
12 # ND=No-Date versions for README
13 ifndef BINDISKINFOND
14 export BINDISKINFOND="$(CAPPROJECT)$(CAPSUBPROJECT) $(DEBVERSION) \"$(CAPCODENAME)\" - $(OFFICIAL) $(FULLARCH)"
15 endif
16-ifndef SRCDISKINFOND
17-export SRCDISKINFOND="$(CAPPROJECT) $(DEBVERSION) \"$(CAPCODENAME)\" - $(OFFICIAL) Source-$$num"
18-endif
19 ifndef BINVOLID
20 ifeq ($(ARCH),powerpc)
21 BINVOLID="$(CAPPROJECT) $(DEBVERSION) ppc"
22@@ -72,9 +66,6 @@ else
23 BINVOLID="$(CAPPROJECT) $(DEBVERSION) $(ARCH)"
24 endif
25 endif
26-ifndef SRCVOLID
27-SRCVOLID="$(CAPPROJECT) $(DEBVERSION) Source $$num"
28-endif
29 ifndef MKISOFS
30 export MKISOFS=/usr/bin/mkisofs
31 endif
32@@ -103,12 +94,10 @@ endif
33 ## Internal variables
34 apt=$(BASEDIR)/tools/apt-selection
35 list2cds=$(BASEDIR)/tools/list2cds
36-list2src=$(BASEDIR)/tools/list2src
37 add_packages=$(BASEDIR)/tools/add_packages
38 add_dirs=$(BASEDIR)/tools/add_dirs
39 add_bin_doc=$(BASEDIR)/tools/add-bin-doc
40 scanpackages=$(BASEDIR)/tools/scanpackages
41-scansources=$(BASEDIR)/tools/scansources
42 add_files=$(BASEDIR)/tools/add_files
43 set_mkisofs_opts=$(BASEDIR)/tools/set_mkisofs_opts
44 add_secured=$(BASEDIR)/tools/add_secured
45@@ -202,16 +191,10 @@ PrintVars:
46 DATE=$${CDIMAGE_DATE:-`date +%Y%m%d`} ; \
47 echo BINDISKINFO: ; \
48 echo $(BINDISKINFO) ; \
49- echo SRCDISKINFO: ; \
50- echo $(SRCDISKINFO) ; \
51 echo BINDISKINFOND: ; \
52 echo $(BINDISKINFOND) ; \
53- echo SRCDISKINFOND: ; \
54- echo $(SRCDISKINFOND) ; \
55 echo BINVOLID: ; \
56 echo $(BINVOLID) ; \
57- echo SRCVOLID: ; \
58- echo $(SRCVOLID) ; \
59
60 default:
61 @echo "Please refer to the README file for more information"
62diff --git a/README b/README
63deleted file mode 100644
64index 3be8e05..0000000
65--- a/README
66+++ /dev/null
67@@ -1,247 +0,0 @@
68-YACS - Yet Another CD Script :-)
69-================================
70-(better known as debian-cd)
71-
72-Copyright 1999-2001 Rapha�l Hertzog <hertzog@debian.org>
73-This set of tools is licensed under the General Public License
74-version 2 or any later version. You can find it in
75-/usr/share/common-licenses/GPL on a Debian GNU system.
76-
77-Thanks to Steve McIntyre <stevem@chiark.greenend.org.uk> for his
78-work on slink_cd/debian_cd. Some ideas come from his script.
79-
80-Thanks to all the contributors on the debian-cd mailing list.
81-
82-What is needed?
83-===============
84-Software:
85-- the apt-get (>= 0.3.11.1) tool
86-- apt-utils (for apt-ftparchive)
87-- perl (>= 5.004)
88-- bash (or another POSIX shell)
89-- make
90-- mkisofs/mkhybrid (mkisofs also provides the isoinfo binary used by the
91- Pseudo Image Kit)
92-- the perl Digest::MD5 module
93-- lynx (for text version of README.html) and todos from sysutils
94- to convert docs to DOS format (although you can rip that out, too)
95-Other:
96-- lots of free space on your disks
97-- a Debian mirror, on a partition where you can write.
98- If you can't write on it then you may try to use a symlink farm,
99- but it's not the recommended way to build Debian CDs.
100-
101-
102- -------------------------------
103- - GENERATING DEBIAN CD IMAGES -
104- -------------------------------
105-
106-
107-For the people that don't have time, here's the quick explanation:
108-==================================================================
109-
110-Edit the CONF.sh and change the PATHs for the mirror and so on.
111-$ sensible-editor CONF.sh
112-$ . CONF.sh
113-$ make distclean
114-$ make apt-setup
115-$ make list COMPLETE=1 SIZELIMIT1=625000000 SRCSIZELIMIT=665000000
116-$ make official_images
117-[ alternatively, if you only want binary images:
118- $ make bin-official_images ]
119-
120-However, you really should consider reading further for more information.
121-You can also take a look at build_all.sh for an automatized way of building
122-CD images.
123-
124-How to build a CD set - step by step
125-====================================
126-
127-If you haven't already, change to the /usr/share/debian-cd/ directory.
128-
129-The process of building a CD is composed of the following steps:
130-
131-- first configure what is needed in CONF.sh and source it in your shell:
132-
133- $ . CONF.sh
134-
135- The exported environment variables will be used by all the
136- tools involved here (Makefiles, perl scripts, shell scripts).
137-
138- If you want to build CD images for more than one arch, you will
139- have to build them one after the other (you may use a shell
140- script for this).
141-
142- Note that the temporary dir must be on the same device than the
143- mirror because debian-cd uses hardlinks for generating an image
144- tree. If you can't do this, you'll have to use the symlink farm.
145- The symlink farm is explained at the end of this README.
146-
147- Keep in mind that the environment variables will stay in the
148- environment after your debian-cd run, and may interfere with
149- other program using the same variables (e.g. kernel-package).
150- So if you want to be 100% safe, run debian-cd in a
151- separate shell that you can leave after you're done.
152-
153-- then we clean everything that may still be there from previous runs:
154-
155- $ make distclean
156-
157-- now we'll check if your mirror is ok (with good Packages files):
158-
159- $ make mirrorcheck
160-
161-- then we initialize the temporary directory used for the build:
162-
163- $ make apt-setup
164-
165-- now you can decide what you want on your CDs
166-
167- $ make list TASK=tasks/debian-2.2 COMPLETE=1
168-
169- or
170-
171- $ make list TASK=tasks/gnome COMPLETE=0 SIZELIMIT=576716800
172-
173- or
174-
175- $ export NONFREE=1; make list TASK=tasks/your-task-here COMPLETE=1
176-
177- or for something like an official image (without non-free) :
178-
179- $ make list COMPLETE=1 SIZELIMIT1=576716800
180-
181- .... take a look at the file tasks/* to see the options you can have :)
182-
183- You can change the behaviour of this command with the following
184- variables:
185- - if NONFREE is set, then packages from non-free will be allowed
186- (NONFREE must be exported to all sub-shells)
187- - if EXTRANONFREE is set, then non-free packages will be included
188- on an extra CD (the last CD in fact). Don't use NONFREE and
189- EXTRANONFREE at the same time !
190- (EXTRANONFREE must be exported to all sub-shells)
191- - if COMPLETE is set, all packages that are not listed in the
192- selected task file will be included at the end
193- - if SIZELIMIT is set, it will be used as the maximum size that
194- we can put into each CD
195- - if SIZELIMIT<X> (with <X> beeing a integer) is set, it will be used
196- as the maximum size of the X'th binary CD. SIZELIMIT<X> overrides
197- SIZELIMIT ...
198-
199- This target calls the target "bin-list" can be used to build only binary
200- CDs.
201-
202-- it may be time to add the disks-arch stuff and to make the CDs bootable:
203-
204- $ make bootable
205-
206- This affects only the binary CDs.
207-
208- Size calculation is imprecise for bootable CDs (usually the first CDs
209- in the set), so you may need to manually adjust SIZELIMIT* variables
210- to account for the size of the booting stuff used.
211-
212-- now, we'll add the binary packages to the temporary tree:
213-
214- $ make packages
215-
216-- if you want to install additional files:
217-
218- $ make bin-extras CD=1 ROOTSRC=/home/ftp/ DIR=goodies/wordperfect
219- $ make src-extras CD=3 ROOTSRC=/home/ftp/ DIR=goodies/kernel-2.3
220-
221- The first will copy /home/ftp/goodies/wordperfect/ to the first binary
222- CD. It will be in <root of the cd>/goodies/wordperfect/. You can call
223- make extras multiple times if you need more.
224-
225- Please note that the files to be copied should be on the same partition
226- than your mirror (unless you use a symlink farm).
227-
228- If you want to do customize your CD even more, you can use the hook
229- system. Read more about that below.
230-
231-- We can add an md5sum.txt file on each CD to enable users to check their
232- files:
233-
234- $ make md5list
235-
236- This calls the targets 'bin-md5list' and 'src-md5list'. You can
237- choose to call only bin-md5list if you're building only binary images.
238-
239-- now we can create the images:
240-
241- $ make images
242-
243- If you don't have enough space for all images, you can generate
244- only one image (of the second binary CD for example) with:
245-
246- $ make bin-image CD=2
247-
248- Of course if you want to build all binary images you'll use:
249-
250- $ make bin-images
251-
252- Note: here we use "make images", but you could as well use
253- "make official_images" since the latter is the same as the former
254- with some dependencies on targets that you already launched
255- (make bootable packages sources).
256-
257-- if you want to generate a MD5SUMS file with the md5sums of the
258- images you can do it with:
259-
260- $ make imagesums
261-
262-
263-Official images
264-===============
265-
266-If you use make official_images you're building CD images that have
267-the same properties than official CD images but they still doesn't
268-have the name of "Official Images". The name of the images is given
269-by setting the OFFICIAL and DEBVERSION environment variable (check
270-CONF.sh).
271-
272-Please never ever use the "Official" name for a CD image that you
273-built yourself. The only images that can be called "Official" are the
274-ones built by Debian itself and which are provided on Debian's
275-servers.
276-
277-The default configuration shipped with this package will automatically
278-name the images "Unofficial". CD will work exactly in the same way
279-with all Debian tools, only the label is different. That means you
280-can use build_all.sh to build your "Unofficial" images without modifying
281-anything.
282-
283-
284-Additional targets
285-==================
286-
287-Image format
288-------------
289-
290-You may want to generate images in ISO 9660 or raw formats.
291-
292-Set the IMAGE_FORMAT variable in CONF.sh. You can choose "iso" for generation
293-of .iso (default), or "img" for generation of raw images.
294-
295-
296-About the symlink farm
297-======================
298-
299-If you don't have write access on the disk where you have the mirror
300-or if for another reason hardlink cannot be used, you can try to
301-use a symlink farm. Instead of having real files, your temporary tree
302-will be filled with symlinks that mkhybrid will change into files when
303-it will build the image. You'll need to use a special options. You
304-have 2 lines of options in CONF.sh as examples.
305-
306-I've never tested the symlink farm ... it may well generate unusable
307-images. Don't use it for ISO images that will used by many users.
308-
309-Note that you will also need a patched mkhybrid that does support the
310--F option. Have a look here about it :
311-http://www.chiark.greenend.org.uk/~stevem/DebianCD/
312-
313-The mkhybrid package in Debian does support this -F option since
314-potato (Debian 2.2).
315diff --git a/build_all.sh b/build_all.sh
316index b3cedc3..8a7686d 100755
317--- a/build_all.sh
318+++ b/build_all.sh
319@@ -1,6 +1,6 @@
320 #!/bin/sh
321
322-# Script to build everything possible : sources and binaries for all archs
323+# Script to build images for all archs
324
325 . ./CONF.sh
326
327@@ -48,11 +48,10 @@ do
328 fi
329 SIZE_ARGS="$SIZE_ARGS SIZELIMIT${CD}=$FULL_SIZE"
330 done
331- FULL_SIZE=`echo "($DEFSRCSIZE - $size) * 1024 * 1024" | bc`
332 echo " ... building the images"
333- make bin-list $SIZE_ARGS SRCSIZELIMIT=$FULL_SIZE
334+ make bin-list $SIZE_ARGS
335 export OUT=$TMP_OUT/$FULLARCH; mkdir -p $OUT
336- make bin-official_images $SIZE_ARGS SRCSIZELIMIT=$FULL_SIZE
337+ make bin-official_images $SIZE_ARGS
338 if [ $? -gt 0 ]; then
339 echo "ERROR WHILE BUILDING OFFICIAL IMAGES !!" >&2
340 if [ "$ATTEMPT_FALLBACK" = "yes" ]; then

Subscribers

People subscribed via source and target branches