Merge ~mwhudson/debian-cd/+git/ubuntu:no-jigdo into ~ubuntu-cdimage/debian-cd/+git/ubuntu:main

Proposed by Michael Hudson-Doyle
Status: Merged
Merged at revision: 8bb92b66d7071e79aa47f833a4941107d9cd9a49
Proposed branch: ~mwhudson/debian-cd/+git/ubuntu:no-jigdo
Merge into: ~ubuntu-cdimage/debian-cd/+git/ubuntu:main
Diff against target: 19 lines (+3/-3)
1 file modified
CONF.sh (+3/-3)
Reviewer Review Type Date Requested Status
Steve Langasek Approve
Review via email: mp+456298@code.launchpad.net

Commit message

Remove -checksum_algorithm_iso from xorriso command line

Slightly surprisingly from the name, these are related to xorriso's
jigdo support which is not enabled in newer releases and thus cause the
xorriso invocations to fail.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

> thus cause the xorriso invocations to fail.

Please point to a log showing this, as far as I know all image builds are succeeding?

Revision history for this message
Steve Langasek (vorlon) :
review: Needs Information
Revision history for this message
Steve Langasek (vorlon) wrote :

Also, further down we have:

case $DIST in
  bionic|focal)
    # temporary hack until such time as we can upgrade all builds to 1.4.2
    new_xorriso="/home/cdimage/xorriso/xorriso-1.2.4/xorriso/xorriso"
    if [ -x "$new_xorriso" ]; then
      export amd64_MKISOFS="$new_xorriso"
      export arm64_MKISOFS="$new_xorriso"
    fi
    ;;

And on the new server, it's:

cdimage@cdimage-master:~/cdimage/www/full$ ls /home/cdimage/xorriso/xorriso-1.2.4/xorriso/xorriso
ls: cannot access '/home/cdimage/xorriso/xorriso-1.2.4/xorriso/xorriso': No such file or directory

So are any of these variables doing anything at all?

Revision history for this message
Steve Langasek (vorlon) wrote :

oops, wait, that's only on bionic and focal and we don't do daily builds of either of those anymore (last used 20230316 for the point release)

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

This comes from trying to run ubuntu-cdimage on my (mantic) laptop. It's not affecting production afaik.

Revision history for this message
Steve Langasek (vorlon) wrote :

thanks for clarifying

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/CONF.sh b/CONF.sh
2index b005f88..5cd4d6e 100644
3--- a/CONF.sh
4+++ b/CONF.sh
5@@ -228,11 +228,11 @@ export UPDATES=1
6 # that will burn correctly onto a CD and also can be written raw to a
7 # USB stick. xorriso 0.6.5 and later has working support for this.
8 export i386_MKISOFS="xorriso"
9-export i386_MKISOFS_OPTS="-as mkisofs -r -checksum_algorithm_iso md5,sha1"
10+export i386_MKISOFS_OPTS="-as mkisofs -r"
11 export amd64_MKISOFS="xorriso"
12-export amd64_MKISOFS_OPTS="-as mkisofs -r -checksum_algorithm_iso md5,sha1 -iso-level 3"
13+export amd64_MKISOFS_OPTS="-as mkisofs -r -iso-level 3"
14 export arm64_MKISOFS="xorriso"
15-export arm64_MKISOFS_OPTS="-as mkisofs -r -checksum_algorithm_iso md5,sha1"
16+export arm64_MKISOFS_OPTS="-as mkisofs -r"
17
18 case $DIST in
19 bionic|focal)

Subscribers

People subscribed via source and target branches