Merge ~mwhudson/curtin:lp-1923487 into curtin:master

[Michael Hudson-Doyle]

block_meta: pass --yes to lvcreate alongside --wipesignatures=y

Otherwise it will not actually wipe the signatures it finds.

LP: #1923487

[Server Team CI bot (server-team-bot)]

FAILED: Continuous integration, rev:3188032e5126b3fd529733f246f118061800710f
https://jenkins.ubuntu.com/server/job/curtin-ci/108/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/108/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/108/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/108/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/108/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/108//rebuild

review: Needs Fixing (continuous-integration)

[Michael Hudson-Doyle (mwhudson)]

The amd64 failure is the pylint flake.

[Dan Bungert (dbungert)]

Manpage supports this change:
-W|--wipesignatures y|n
Controls detection and subsequent wiping of signatures on new
LVs. There is a prompt for each signature detected to confirm
its wiping (unless --yes is used to override confirmations.)

review: Approve

[Server Team CI bot (server-team-bot)]

review: Approve (continuous-integration)

diff --git a/curtin/commands/block_meta.py b/curtin/commands/block_meta.py
index cf6bc02..29f3969 100644
--- a/curtin/commands/block_meta.py
+++ b/curtin/commands/block_meta.py
@@ -1324,7 +1324,7 @@ def lvm_partition_handler(info, storage_config):
         cmd = ["lvcreate", volgroup, "--name", name, "--zero=y"]
         release = distro.lsb_release()['codename']
         if release not in ['precise', 'trusty']:
-            cmd.extend(["--wipesignatures=y"])
+            cmd.extend(["--wipesignatures=y", "--yes"])
 
         if info.get('size'):
             size = util.human2bytes(info["size"])