Merge lp:~mwasilew/linaro-android-build-tools/check-file-exists into lp:linaro-android-build-tools

Proposed by Milosz Wasilewski
Status: Merged
Merged at revision: 655
Proposed branch: lp:~mwasilew/linaro-android-build-tools/check-file-exists
Merge into: lp:linaro-android-build-tools
Diff against target: 22 lines (+6/-4)
1 file modified
build-scripts/create-user-build-script (+6/-4)
To merge this branch: bzr merge lp:~mwasilew/linaro-android-build-tools/check-file-exists
Reviewer Review Type Date Requested Status
Milo Casagrande (community) Approve
Review via email: mp+168417@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Milo Casagrande (milo) wrote :

Hello Milosz,

apologies for the delay.
The changes look good, were you also able to test them?

review: Approve
Revision history for this message
Milosz Wasilewski (mwasilew) wrote :

> Hello Milosz,
>
> apologies for the delay.
> The changes look good, were you also able to test them?

I briefly tested on an existing script before posting merge request.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'build-scripts/create-user-build-script'
2--- build-scripts/create-user-build-script 2013-05-28 08:47:33 +0000
3+++ build-scripts/create-user-build-script 2013-06-10 11:51:38 +0000
4@@ -121,12 +121,14 @@
5 EOF
6 if [ -n "$SOURCE_OVERLAY" ]; then
7 cat <<EOF
8-if [ "a\$MANIFEST" == "a" -a \$EXACT -eq 1 ]; then
9- echo "ERROR: no pinned manifest provided. Please download from $PINNED_MANIFEST_URL. This must be done from a browser that accepts cookies."
10- exit 1
11+if [ \$EXACT -eq 1 ]; then
12+ if [ "a\$MANIFEST" == "a" -o ! -f \$MANIFEST ]; then
13+ echo "ERROR: no pinned manifest provided. Please download from $PINNED_MANIFEST_URL. This must be done from a browser that accepts cookies."
14+ exit 1
15+ fi
16 fi
17 if [ \$SOURCE_OVERLAY_OPTIONAL -ne 1 ]; then
18- if [ "a\$SOURCE_OVERLAY" == "a" ]; then
19+ if [ "a\$SOURCE_OVERLAY" == "a" -o ! -f \$SOURCE_OVERLAY ]; then
20 echo "ERROR: no source overlay provided. Please download from http://snapshots.linaro.org/android/binaries/$SOURCE_OVERLAY. This must be done from a browser that accepts cookies."
21 exit 1
22 fi

Subscribers

People subscribed via source and target branches