Merge lp:~mwaddel/linaro-image-tools/vexpress-uInitrd-v2 into lp:linaro-image-tools/11.11
Proposed by
Matt Waddel
Status: | Merged |
---|---|
Merged at revision: | 49 |
Proposed branch: | lp:~mwaddel/linaro-image-tools/vexpress-uInitrd-v2 |
Merge into: | lp:linaro-image-tools/11.11 |
Diff against target: |
16 lines (+4/-2) 1 file modified
linaro-media-create (+4/-2) |
To merge this branch: | bzr merge lp:~mwaddel/linaro-image-tools/vexpress-uInitrd-v2 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Loïc Minier (community) | Approve | ||
Review via email:
|
Description of the change
Adds the uInitrd to the SD/MMC deploy process. This version incorporates feedback from Loic's review.
To post a comment you must log in.
This is ok
I appreciate the effort to quote one use of ${DIR}, obviously the other uses should be quoted as well.
I note you used: "/disk/ uInitrd
"${DIR}
I usually write:
"$DIR/disk/uInitrd"
(i.e. use a single pair of double-quotes rather than multiple pairs; "$foo/$bar" rather than "$foo"/"$baz"; also don't use ${} if not needed)
and if you need wildcards, stop the quotes just before them, instead of: binary/ ${parts_ dir}/initrd. img-*-linaro- vexpress $parts_ dir/initrd. img-"*- linaro- vexpress $parts_ dir/initrd. img-"*" -linaro- vexpress"
${DIR}/
use:
"$DIR/binary/
or:
"$DIR/binary/