Merge lp:~mwaddel/linaro-image-tools/vexpress-uInitrd-v2 into lp:linaro-image-tools/11.11

Proposed by Matt Waddel
Status: Merged
Merged at revision: 49
Proposed branch: lp:~mwaddel/linaro-image-tools/vexpress-uInitrd-v2
Merge into: lp:linaro-image-tools/11.11
Diff against target: 16 lines (+4/-2)
1 file modified
linaro-media-create (+4/-2)
To merge this branch: bzr merge lp:~mwaddel/linaro-image-tools/vexpress-uInitrd-v2
Reviewer Review Type Date Requested Status
Loïc Minier (community) Approve
Review via email: mp+34258@code.launchpad.net

Description of the change

Adds the uInitrd to the SD/MMC deploy process. This version incorporates feedback from Loic's review.

To post a comment you must log in.
Revision history for this message
Loïc Minier (lool) wrote :

This is ok

I appreciate the effort to quote one use of ${DIR}, obviously the other uses should be quoted as well.

I note you used:
"${DIR}"/disk/uInitrd

I usually write:
"$DIR/disk/uInitrd"
(i.e. use a single pair of double-quotes rather than multiple pairs; "$foo/$bar" rather than "$foo"/"$baz"; also don't use ${} if not needed)

and if you need wildcards, stop the quotes just before them, instead of:
${DIR}/binary/${parts_dir}/initrd.img-*-linaro-vexpress
use:
"$DIR/binary/$parts_dir/initrd.img-"*-linaro-vexpress
or:
"$DIR/binary/$parts_dir/initrd.img-"*"-linaro-vexpress"

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'linaro-media-create'
2--- linaro-media-create 2010-08-31 20:57:05 +0000
3+++ linaro-media-create 2010-08-31 23:28:41 +0000
4@@ -215,8 +215,10 @@
5 sudo tar --strip-components=5 -C ${DIR}/disk/ -xf $BINARY_TARBALL binary/usr/lib/u-boot/ca9x4_ct_vxp/u-boot.bin
6 sudo mkimage -A arm -O linux -T kernel -C none -a 0x60008000 -e 0x60008000 \
7 -n "Linux" -d ${DIR}/binary/${parts_dir}/vmlinuz*-vexpress ${DIR}/disk/uImage
8- # TODO add uInitrd once we have daily images
9- #sudo cp -f ${DIR}/binary/${parts_dir}/uInitrd.vexpress ${DIR}/disk/uInitrd
10+ sudo mkimage -A arm -O linux -T ramdisk -C none -a 0x81000000 \
11+ -e 0x81000000 -n "initramfs" -d \
12+ ${DIR}/binary/${parts_dir}/initrd.img-*-linaro-vexpress \
13+ "${DIR}"/disk/uInitrd
14 ;;
15 *)
16 echo "Set --dev parameter: --dev <beagle|vexpress>" 1>&2

Subscribers

People subscribed via source and target branches