Merge lp:~mvo/webbrowser-app/multiarch-fixes into lp:webbrowser-app

Proposed by Michael Vogt
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 632
Merged at revision: 639
Proposed branch: lp:~mvo/webbrowser-app/multiarch-fixes
Merge into: lp:webbrowser-app
Diff against target: 30 lines (+3/-3)
1 file modified
debian/control (+3/-3)
To merge this branch: bzr merge lp:~mvo/webbrowser-app/multiarch-fixes
Reviewer Review Type Date Requested Status
Olivier Tilloy Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+227755@code.launchpad.net

Commit message

debian/control: update libqt5webkit5-qmlwebkitplugin -> qml-module-qtwebkit (fixes a multiarch install failure)

Description of the change

Trivial fix to update the dependencies from the transitional libqt5webkit5-qmlwebkitplugin to the real qml-module-qtwebkit - this fixes a multiarch install failure.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

The change looks good, thanks for taking care of this Michael.

I wonder if the new entry in debian/changelog is really necessary? And if the CI train will deal gracefully with it?

Usually when I modify files under debian/, I don’t add a new changelog entry, but I make sure they are documented in the commit message, which is what the CI train picks up to build its own changelog entry. But you probably know better than me how it all works.

review: Approve
632. By Michael Vogt

debian/control:
- update libqt5webkit5-qmlwebkitplugin -> qml-module-qtwebkit

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks Olivier for your quick review!

I agree that the changelog entry is unneeded, I still need to get used to the new citrain world order (I tend to forget when in a rush) :) I removed the unneeded entry now.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-07-09 16:36:52 +0000
3+++ debian/control 2014-07-23 07:59:55 +0000
4@@ -8,7 +8,7 @@
5 hardening-wrapper,
6 python3-all,
7 libqt5sql5-sqlite,
8- libqt5webkit5-qmlwebkitplugin,
9+ qml-module-qtwebkit,
10 liboxideqt-qmlplugin (>= 1.0.2),
11 qt5-default,
12 qt5-qmake,
13@@ -58,7 +58,7 @@
14 fonts-liberation,
15 liboxideqt-qmlplugin (>= 1.1),
16 libqt5sql5-sqlite,
17- libqt5webkit5-qmlwebkitplugin,
18+ qml-module-qtwebkit,
19 qtdeclarative5-accounts-plugin,
20 qtdeclarative5-qtquick2-plugin (>= 5.2),
21 qtdeclarative5-ubuntu-ui-extras-browser-plugin (= ${binary:Version}),
22@@ -77,7 +77,7 @@
23 Pre-Depends: ${misc:Pre-Depends}
24 Depends: ${misc:Depends},
25 ${shlibs:Depends},
26- libqt5webkit5-qmlwebkitplugin,
27+ qml-module-qtwebkit,
28 qtdeclarative5-qtquick2-plugin,
29 qtdeclarative5-ubuntu-ui-toolkit-plugin,
30 qtdeclarative5-ubuntu-web-plugin (= ${binary:Version}),

Subscribers

People subscribed via source and target branches

to status/vote changes: