Code review comment for lp:~mvo/unity-scope-click/get-language-base-exceptions

Revision history for this message
dobey (dobey) wrote :

David, this isn't about translations of the app in Launchpad exactly, I don't think. The issue here is mainly with how we are submitting reviews to the server, and possibly with how we are fetching those reviews (though currently, the server is not filtering on Accept-Language and simply returns all reviews).

However, returning the full language string from get_language_base() is I think the wrong answer in any case. It should always return the base string for the language. Changing it can break other things (such as get_accept_languages()). I'm disapproving this branch, because I think this is the wrong place/way to do this.

review: Disapprove

« Back to merge proposal