Merge lp:~mvo/unity-scope-click/get-language-base-exceptions into lp:unity-scope-click/devel
Proposed by
Michael Vogt
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | dobey | ||||
Proposed branch: | lp:~mvo/unity-scope-click/get-language-base-exceptions | ||||
Merge into: | lp:unity-scope-click/devel | ||||
Diff against target: |
47 lines (+14/-1) 3 files modified
scope/click/configuration.cpp (+6/-0) scope/tests/test_configuration.cpp (+7/-0) scope/tests/test_reviews.cpp (+1/-1) |
||||
To merge this branch: | bzr merge lp:~mvo/unity-scope-click/get-language-base-exceptions | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
dobey (community) | Disapprove | ||
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Review via email: mp+220054@code.launchpad.net |
Description of the change
This branch ensures that review results for zh_CN/zh_TW and pt/pt_BR are not mixed but instead handled as their own base-languages. This is what we have done in software-center too.
If for some reason this is no longer needed please let me know and just close the MP.
Thanks for your consideration,
Michael
To post a comment you must log in.
Unmerged revisions
- 263. By Michael Vogt
-
For click reviews get_language_base() is used. But the above languages
are different enough so that they should not get results from the
generic zh/pt language.
FAILED: Continuous integration, rev:263 /code.launchpad .net/~mvo/ unity-scope- click/get- language- base-exceptions /+merge/ 220054/ +edit-commit- message
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http:// jenkins. qa.ubuntu. com/job/ unity-team- unity-scope- click-devel- ci/69/ jenkins. qa.ubuntu. com/job/ unity-team- unity-scope- click-devel- utopic- amd64-ci/ 44 jenkins. qa.ubuntu. com/job/ unity-team- unity-scope- click-devel- utopic- armhf-ci/ 43 jenkins. qa.ubuntu. com/job/ unity-team- unity-scope- click-devel- utopic- armhf-ci/ 43/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ unity-team- unity-scope- click-devel- utopic- i386-ci/ 43
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity- team-unity- scope-click- devel-ci/ 69/rebuild
http://