Merge lp:~mvo/ubuntuone-installer/lp853060 into lp:ubuntuone-installer

[Michael Vogt]

This should fix bug #853060 by checking for the exit-status. Someone will have to test it.

[lp:~mvo/ubuntuone-installer/lp853060]

27. By Michael Vogt on 2012-05-09

empty --fixes commit for #853060

[dobey (dobey)]

I'm trying to reproduce the problem, but only get a working result. Would like to understand what is going wrong exactly for people so we can have a proper test case for regression testing.

review: Needs Information

[Michael Vogt (mvo)]

As was pointed out, this needs some more work to actually show a proper error dialog.
aptdaemon does support this via ready-made gtk/gtk3 error dialogs that we need to wire in.

[dobey (dobey)]

Rejected this one, as I have a branch in the works which adds error handling and such.

Unmerged revisions

27. By Michael Vogt on 2012-05-09

empty --fixes commit for #853060

26. By Michael Vogt on 2012-05-09

ubuntuone/installer/gui.py: check for exit-status before launching CONTROL_PANEL_COMMAND

=== modified file 'ubuntuone/installer/gui.py'
--- ubuntuone/installer/gui.py	2012-03-13 20:24:31 +0000
+++ ubuntuone/installer/gui.py	2012-05-09 18:42:17 +0000
@@ -16,6 +16,7 @@
 """The GUI of the Ubuntu One Installer."""
 
 import aptdaemon.gtk3widgets as aptgtk
+import aptdaemon.enums
 import aptdaemon.client as aptclient
 import gettext
 import os
@@ -369,8 +370,9 @@
         """Install the packages."""
         self.__apt_progress.set_fraction(0.0)
 
-        def finished(*args, **kwargs):
-            GLib.spawn_command_line_async(CONTROL_PANEL_COMMAND)
+        def finished(trans, exit_status):
+            if exit_status == aptdaemon.enums.EXIT_SUCCESS:
+                GLib.spawn_command_line_async(CONTROL_PANEL_COMMAND)
             Gtk.main_quit()
 
         transaction = yield self.client.install_packages(