Merge lp:~mvo/ubuntu-release-upgrader/unity-3d-support-test into lp:ubuntu-release-upgrader

Proposed by Michael Vogt
Status: Merged
Approved by: Michael Terry
Approved revision: 2551
Merged at revision: 2548
Proposed branch: lp:~mvo/ubuntu-release-upgrader/unity-3d-support-test
Merge into: lp:ubuntu-release-upgrader
Diff against target: 0 lines
To merge this branch: bzr merge lp:~mvo/ubuntu-release-upgrader/unity-3d-support-test
Reviewer Review Type Date Requested Status
Michael Terry Approve
Review via email: mp+118775@code.launchpad.net

Description of the change

This adds a check for unity-3d support during the upgrade as it appears that the 2d version is going to be dropped.

To post a comment you must log in.
2550. By Michael Vogt

implement detection of untiy (as didrocks suggested)

2551. By Michael Vogt

merged lp:~didrocks/ubuntu-release-upgrader/unity-3d-support-test, many thanks

Revision history for this message
Michael Terry (mterry) wrote :

Looks fine. You use both ret and res as variable names for separate subprocess.call returns, which may lead to confusion someday. But no big deal. And the wiki page doesn't exist yet.

review: Approve
2552. By Michael Vogt

use return_code instead of ret/res, thanks to Mike Terry

Revision history for this message
Michael Vogt (mvo) wrote :

On Fri, Aug 10, 2012 at 02:28:32PM -0000, Michael Terry wrote:
> Review: Approve
>
> Looks fine. You use both ret and res as variable names for separate subprocess.call returns, which may lead to confusion someday. But no big deal. And the wiki page doesn't exist yet.

Great, thanks. I fixed the res/ret confusion to "return_code" and
created a stub wiki page. The unity team hopefully fills that with
life.

Cheers,
 Michael

Preview Diff

Empty

Subscribers

People subscribed via source and target branches