Merge lp:~mvo/software-properties/dep8 into lp:software-properties

Proposed by Michael Vogt
Status: Merged
Approved by: Martin Pitt
Approved revision: 795
Merged at revision: 798
Proposed branch: lp:~mvo/software-properties/dep8
Merge into: lp:software-properties
Diff against target: 31 lines (+10/-0)
3 files modified
debian/control (+1/-0)
debian/tests/control (+2/-0)
debian/tests/run-tests (+7/-0)
To merge this branch: bzr merge lp:~mvo/software-properties/dep8
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Michael Vogt (community) Needs Resubmitting
Review via email: mp+121378@code.launchpad.net

Description of the change

add dep8 testing header

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Please note that you also need to add a "XS-Testsuite: autopkgtest" header to the source stanza in debian/control for this to work.

17 +(cd tests ; xvfb-run make )

Why do you run this in a subshell? That shouldn't be necessary, but of course does not actually hurt either.

review: Needs Fixing
lp:~mvo/software-properties/dep8 updated
794. By Michael Vogt

debian/control: add missing XS-Testsuite header

795. By Michael Vogt

debian/tests/run-tests: no need to run a subshell, thanks to Martin Pitt

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks Martin, I fixed both issues and it should be ready for re-review or merge.

review: Needs Resubmitting
Revision history for this message
Martin Pitt (pitti) wrote :

LGTM, thanks! Please upload.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2012-07-18 13:12:13 +0000
3+++ debian/control 2012-09-10 07:35:23 +0000
4@@ -13,6 +13,7 @@
5 dh-translations
6 Standards-Version: 3.9.3
7 Vcs-Bzr: http://code.launchpad.net/~ubuntu-core-dev/software-properties/main
8+XS-Testsuite: autopkgtest
9
10 Package: python-software-properties
11 Section: python
12
13=== added directory 'debian/tests'
14=== added file 'debian/tests/control'
15--- debian/tests/control 1970-01-01 00:00:00 +0000
16+++ debian/tests/control 2012-09-10 07:35:23 +0000
17@@ -0,0 +1,2 @@
18+Tests: run-tests
19+Depends: @, xvfb
20
21=== added file 'debian/tests/run-tests'
22--- debian/tests/run-tests 1970-01-01 00:00:00 +0000
23+++ debian/tests/run-tests 2012-09-10 07:35:23 +0000
24@@ -0,0 +1,7 @@
25+#!/bin/sh
26+
27+set -e
28+
29+cd tests
30+xvfb-run make
31+

Subscribers

People subscribed via source and target branches

to status/vote changes: