Merge lp:~mvo/software-center/workaround-css-memleak into lp:software-center

Proposed by Michael Vogt
Status: Merged
Merged at revision: 3234
Proposed branch: lp:~mvo/software-center/workaround-css-memleak
Merge into: lp:software-center
Diff against target: 36 lines (+6/-3)
1 file modified
data/ui/gtk3/css/softwarecenter.css (+6/-3)
To merge this branch: bzr merge lp:~mvo/software-center/workaround-css-memleak
Reviewer Review Type Date Requested Status
software-store-developers Pending
Review via email: mp+129830@code.launchpad.net

Description of the change

This branch removes the usage of "text-shadow" as this causes a rather
big memory leak with the current gtk. After talking to mpt about the
subtle visual changes this involved he suggested to remove the text-shadow
permanently as it improves the visual UI. So this branch is doing that
now.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/ui/gtk3/css/softwarecenter.css'
2--- data/ui/gtk3/css/softwarecenter.css 2012-07-19 09:29:16 +0000
3+++ data/ui/gtk3/css/softwarecenter.css 2012-10-16 09:27:00 +0000
4@@ -1,6 +1,11 @@
5 @define-color light-aubergine #DED7DB;
6 @define-color super-light-aubergine #F4F1F3;
7
8+/*
9+ do not use text-shadow until bugzilla.gnome.org bug #686209 is
10+ fixed - its leaking memory
11+*/
12+
13
14 #featured-star {
15 border-color: #F89516; /* yellow */
16@@ -31,7 +36,6 @@
17 -GtkWidget-link-color: shade (@super-light-aubergine, 0.5);
18 -GtkWidget-visited-link-color: shade (@super-light-aubergine, 0.6);
19 color: shade (@super-light-aubergine, 0.5); /* non-link text color */
20- text-shadow: 0 1 2 lighter (@super-light-aubergine);
21 }
22
23 .cellrenderer-button {
24@@ -53,11 +57,10 @@
25 color: darker (@light-aubergine);
26 background-color: shade (@super-light-aubergine, 0.925);
27 border-color: shade (@super-light-aubergine, 0.875);
28- text-shadow: 0 1 2 white;
29 }
30
31 .frame-header-title {
32- text-shadow: 0 1 2 white;
33+ /* intentionally left blank */
34 }
35
36 .item-view-separator {

Subscribers

People subscribed via source and target branches