Merge lp:~mvo/software-center/video-ui-reshuffle into lp:software-center

Proposed by Michael Vogt
Status: Merged
Merged at revision: 2747
Proposed branch: lp:~mvo/software-center/video-ui-reshuffle
Merge into: lp:software-center
Diff against target: 42 lines (+9/-9)
1 file modified
softwarecenter/ui/gtk3/views/appdetailsview.py (+9/-9)
To merge this branch: bzr merge lp:~mvo/software-center/video-ui-reshuffle
Reviewer Review Type Date Requested Status
Gary Lasker (community) Approve
Review via email: mp+93013@code.launchpad.net

Description of the change

Trivial branch that just shuffles the video around a bit to ensure the user finds it more easily.

To post a comment you must log in.
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Looks good, thanks mvo!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/ui/gtk3/views/appdetailsview.py'
2--- softwarecenter/ui/gtk3/views/appdetailsview.py 2012-02-14 08:50:09 +0000
3+++ softwarecenter/ui/gtk3/views/appdetailsview.py 2012-02-14 15:30:44 +0000
4@@ -61,6 +61,7 @@
5 from softwarecenter.ui.gtk3.widgets.stars import Star, StarRatingsWidget
6 from softwarecenter.ui.gtk3.widgets.description import AppDescription
7 from softwarecenter.ui.gtk3.widgets.thumbnail import ScreenshotGallery
8+from softwarecenter.ui.gtk3.widgets.videoplayer import VideoPlayer
9 from softwarecenter.ui.gtk3.widgets.weblivedialog import (
10 ShowWebLiveServerChooserDialog)
11 from softwarecenter.ui.gtk3.gmenusearch import GMenuSearcher
12@@ -1138,6 +1139,14 @@
13 frame.add(self.screenshot)
14 right_vb.pack_start(frame, False, False, 0)
15
16+ # video
17+ mini_hb = Gtk.HBox()
18+ self.videoplayer = VideoPlayer()
19+ mini_hb.pack_start(self.videoplayer, False, False, 0)
20+ # add a empty label here to ensure bg is set properly
21+ mini_hb.pack_start(Gtk.Label(), True, True, 0)
22+ right_vb.pack_start(mini_hb, False, False, 0)
23+
24 # the weblive test-drive stuff
25 self.weblive = get_weblive_backend()
26 if self.weblive.client is not None:
27@@ -1163,15 +1172,6 @@
28 self.support_btn.set_name("subtle-label")
29 self.support_btn.connect('activate-link', self._on_homepage_clicked)
30
31- # video
32- from softwarecenter.ui.gtk3.widgets.videoplayer import VideoPlayer
33- mini_hb = Gtk.HBox()
34- self.videoplayer = VideoPlayer()
35- mini_hb.pack_start(self.videoplayer, False, False, 0)
36- # add a empty label here to ensure bg is set properly
37- mini_hb.pack_start(Gtk.Label(), True, True, 0)
38- vb.pack_start(mini_hb, False, False, 0)
39-
40 # add the links footer to the description widget
41 footer_hb = Gtk.HBox(spacing=6)
42 footer_hb.pack_start(self.homepage_btn, False, False, 0)

Subscribers

People subscribed via source and target branches