Ubuntu Software Center

Merge lp:~mvo/software-center/submit-review-hang-fix into lp:software-center

  1. submit-review-hang-fix
  2. Merge into trunk
Proposed by Michael Vogt
Status: Merged
Merged at revision: 2735
Proposed branch: lp:~mvo/software-center/submit-review-hang-fix
Merge into: lp:software-center
Diff against target: 22 lines (+5/-0)
1 file modified
utils/submit_review_gtk3.py (+5/-0)
To merge this branch: bzr merge lp:~mvo/software-center/submit-review-hang-fix
Reviewer Review Type Date Requested Status
Gary Lasker (community) Approve
Review via email: mp+92291@code.launchpad.net

Description of the change

Small branch to fix hang on precise when submiting a review. The spinner hangs because the threads are not inited.
Now that is funny (for some defintion of funny) because the docs claim the thread_init() is no longer needed.

To post a comment you must log in.
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Haha! Rock!!

Thanks mvo. :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'utils/submit_review_gtk3.py'
2--- utils/submit_review_gtk3.py 2012-01-19 20:54:21 +0000
3+++ utils/submit_review_gtk3.py 2012-02-09 15:25:13 +0000
4@@ -45,6 +45,10 @@
5 #import httplib2
6 #httplib2.debuglevel = 1
7
8+# the glib docs tell us that this is no longer needed, but if its omited
9+# the system will hang on submit *sigh*
10+from gi.repository import GLib
11+GLib.threads_init()
12
13 if __name__ == "__main__":
14 try:
15@@ -71,6 +75,7 @@
16 backupCount=5)
17 logfile_handler.setLevel(logging.INFO)
18 logging.getLogger().addHandler(logfile_handler)
19+ logging.getLogger().addHandler(logging.StreamHandler())
20
21 # run review personality
22 if "submit_review" in sys.argv[0]:

Subscribers

People subscribed via source and target branches