Merge lp:~mvo/software-center/review-fixes into lp:software-center

Proposed by Michael Vogt
Status: Merged
Merged at revision: 2824
Proposed branch: lp:~mvo/software-center/review-fixes
Merge into: lp:software-center
Diff against target: 19 lines (+0/-2)
1 file modified
softwarecenter/backend/reviews/rnr.py (+0/-2)
To merge this branch: bzr merge lp:~mvo/software-center/review-fixes
Reviewer Review Type Date Requested Status
Kiwinote Approve
Review via email: mp+96561@code.launchpad.net

Description of the change

Small branch that fixes leftover broken code from a previuos merge in the reviews.

To post a comment you must log in.
Revision history for this message
Kiwinote (kiwinote) wrote :

looks good - during testing i did notice however that the review i submitted wasn't displayed as first in the list as one might expect, but it is a good improvement, hence merged - much thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/backend/reviews/rnr.py'
2--- softwarecenter/backend/reviews/rnr.py 2012-01-19 18:28:41 +0000
3+++ softwarecenter/backend/reviews/rnr.py 2012-03-08 12:48:20 +0000
4@@ -210,7 +210,6 @@
5 successfully the callback is triggered with the new reviews
6 """
7 LOG.debug("_on_submit_review_data")
8- return
9 # read stdout from submit_review
10 review = ReviewDetails.from_dict(review_json)
11 # FIXME: ideally this would be stored in ubuntu-sso-client
12@@ -356,7 +355,6 @@
13 def _on_modify_review_finished(self, spawn_helper, review_json, review_id, callback):
14 """called when modify_review finished"""
15 LOG.debug("_on_modify_review_finished")
16- return
17 #review_json = spawn_helper._stdout
18 mod_review = ReviewDetails.from_dict(review_json)
19 for (app, reviews) in self._reviews.items():

Subscribers

People subscribed via source and target branches