Merge lp:~mvo/software-center/region-whitelist-lp1006570 into lp:software-center
Proposed by
Michael Vogt
on 2012-09-10
Status: | Merged |
---|---|
Merged at revision: | 3158 |
Proposed branch: | lp:~mvo/software-center/region-whitelist-lp1006570 |
Merge into: | lp:software-center |
Diff against target: |
217 lines (+93/-28) 4 files modified
softwarecenter/db/update.py (+29/-10) softwarecenter/region.py (+2/-0) tests/test_database.py (+60/-17) tests/utils.py (+2/-1) |
To merge this branch: | bzr merge lp:~mvo/software-center/region-whitelist-lp1006570 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gary Lasker (community) | 2012-09-10 | Approve on 2012-09-11 | |
Review via email:
|
Commit message
Fix missing region whitelist support that is used by the software-
Description of the change
Add support for the region-whitelist feature requested in LP: #1006570
To post a comment you must log in.
Anthony Lenton (elachuni) wrote : | # |
lp:~mvo/software-center/region-whitelist-lp1006570
updated
on 2012-09-10
- 3156. By Michael Vogt on 2012-09-10
-
use .lower() on the tags and update test to simulate passing uppercase tags (like the server is doing)
- 3157. By Michael Vogt on 2012-09-10
-
drive-by-cleanup
- 3158. By Michael Vogt on 2012-09-10
-
another small drive-by-cleanup that allows to give make_software_
center_ agent_app_ dict() a override dict - 3159. By Michael Vogt on 2012-09-10
-
trivial pep8 fixes
Michael Vogt (mvo) wrote : | # |
Thanks, good point, I fixed that now and updated the test.
Gary Lasker (gary-lasker) wrote : | # |
This looks fine. Approval also based on Anthony's comment above and Michael's subsequent updates per his comment.
Many thanks!
review:
Approve
Hi mvo!
Awesome, thanks for the fix. It probably makes sense to lowercase/uppercase the tags retrieved from the API, to make the feature case-insensitive. For example, in the API I see "whitelist- iso3166: :US" for an app atm, it would be great if that case just works.