Ubuntu Software Center

Merge lp:~mvo/software-center/recommendations-opt-out into lp:software-center

  1. recommendations-opt-out
  2. Merge into trunk
Proposed by Michael Vogt
Status: Merged
Merged at revision: 2883
Proposed branch: lp:~mvo/software-center/recommendations-opt-out
Merge into: lp:software-center
Diff against target: 15 lines (+5/-0)
1 file modified
softwarecenter/ui/gtk3/widgets/recommendations.py (+5/-0)
To merge this branch: bzr merge lp:~mvo/software-center/recommendations-opt-out
Reviewer Review Type Date Requested Status
Gary Lasker (community) Approve
Review via email: mp+98273@code.launchpad.net

Description of the change

A small fix for duplication of entries on opt-in/opt-out/opt-in

To post a comment you must log in.
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Thanks mvo! Does the trick!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/ui/gtk3/widgets/recommendations.py'
2--- softwarecenter/ui/gtk3/widgets/recommendations.py 2012-03-19 16:12:10 +0000
3+++ softwarecenter/ui/gtk3/widgets/recommendations.py 2012-03-19 19:39:30 +0000
4@@ -197,6 +197,11 @@
5 self.remove_more_button()
6 self.show_all()
7 self.emit("recommendations-opt-out")
8+ try:
9+ self.recommender_agent.disconnect_by_func(self._on_profile_submitted)
10+ self.recommender_agent.disconnect_by_func(self._on_profile_submitted_error)
11+ except TypeError:
12+ pass
13
14 def _upload_user_profile_and_get_recommendations(self):
15 # initiate upload of the user profile here

Subscribers

People subscribed via source and target branches