Merge lp:~mvo/software-center/piston-generic-helper-offline-mode into lp:software-center

[Michael Vogt]

Tiny branch that adds support for offline mode to the generic-helper just like for the piston_get_reviews_helper.py

Note that we could backport this at some point, but we need to be careful about regressions (I can't think
of any currently, but that does not mean anything ;)

[Gary Lasker (gary-lasker)]

Very cool! I can see lobby recommendations now even when offline. This is a great kickoff to building up a nicely effective offline experience. Thanks Michael!

I'll merge this to trunk, and we can decide about backporting later.

review: Approve

[Gary Lasker (gary-lasker)]

...effective offline *recommendations* experience, to be more specific.

=== modified file 'utils/piston-helpers/piston_generic_helper.py'
--- utils/piston-helpers/piston_generic_helper.py	2012-04-25 08:15:28 +0000
+++ utils/piston-helpers/piston_generic_helper.py	2012-05-25 12:28:29 +0000
@@ -159,6 +159,9 @@
                         help="setup alternative datadir")
     parser.add_argument("--ignore-cache", action="store_true", default=False,
                         help="force ignore cache")
+    parser.add_argument("--disable-offline-mode", action="store_true", 
+                        default=False,
+                        help="force disable offline mode")
     parser.add_argument("--needs-auth", default=False, action="store_true",
                         help="need oauth credentials")
     parser.add_argument("--output", default="pickle",
@@ -213,8 +216,14 @@
     try:
         piston_reply = f(**kwargs)
     except httplib2.ServerNotFoundError as e:
-        LOG.warn(e)
-        sys.exit(1)
+        if not args.disable_offline_mode:
+            # switch to offline mode and try again from the cache
+            try:
+                api._offline_mode = True
+                piston_reply = f(**kwargs)
+            except Exception as e:
+                LOG.warn(e)
+                sys.exit(1)
     except APIError as e:
         LOG.warn(e)
         sys.exit(1)