Merge lp:~mvo/software-center/lp1225885 into lp:software-center

[Michael Vogt]

A tiny branch to avoid crashing if a aptdaemon transaction contains no package data (LP: #1225885).

This is crash #3 on errors.ubuntu.com today.

[Michael Vogt (mvo)]

Fwiw, I'm happy to handle the upload once this lands.

[Natalia Bidart (nataliabidart)]

Setting MP as Rejected to reduce numbers of landing candidates in @reviewlist. Change status again if this MP is still current.

[dobey (dobey)]

review: Approve

=== modified file 'README'
--- README	2012-05-22 12:13:02 +0000
+++ README	2014-04-10 09:30:36 +0000
@@ -21,7 +21,8 @@
 You can run a developer instance with:
 
 python setup.py build
-./software-center
+PYTHONPATH=./build/lib.linux-x86_64-2.7 ./bin/software-center
+(the PYTHONPATH needs to be adjusted depending on the architecture)
 
 The initial launch of this will take a bit as it will build a private
 search database but this is only needed once.

=== modified file 'softwarecenter/db/pkginfo_impl/aptcache.py'
--- softwarecenter/db/pkginfo_impl/aptcache.py	2012-12-18 10:23:55 +0000
+++ softwarecenter/db/pkginfo_impl/aptcache.py	2014-04-10 09:30:36 +0000
@@ -588,10 +588,13 @@
 
     # space calculation stuff
     def _on_total_size_calculation_done(self, trans, space):
-        pkgname = trans.packages[0][0]
-        self.emit(
-            "query-total-size-on-install-done",
-            pkgname, trans.download, trans.space)
+        # ensure trans contains the data we expect, see LP: #1225885
+        if trans.packages and trans.packages[0]:
+            pkgname = trans.packages[0][0]
+            self.emit(
+                "query-total-size-on-install-done",
+                pkgname, trans.download, trans.space)
+            
 
     def _on_trans_simulate_error(self, error):
         LOG.exception("simulate failed")