Merge lp:~mvo/software-center/lp1051829 into lp:software-center

[Michael Vogt]

This branch stops reporting errors about bad-quality deb packages as
there are too many of them in the wild and we know that already ;)

This fixes the largest source of recoverable reports from #1051829

=== modified file 'softwarecenter/backend/installbackend_impl/aptd.py'
--- softwarecenter/backend/installbackend_impl/aptd.py	2012-10-02 16:23:45 +0000
+++ softwarecenter/backend/installbackend_impl/aptd.py	2012-10-05 08:53:20 +0000
@@ -1019,6 +1019,11 @@
                 # ... and display as a dialog
                 self.ui.error(None, summary, text)
                 return
+
+        # lintian errors are ignored and not send to apport_recoverable_error
+        if trans.error_code == enums.ERROR_INVALID_PACKAGE_FILE:
+            return
+
         # show a apport recoverable error dialog to the user as we want
         # to know about these issues
         self._call_apport_recoverable_error(

=== modified file 'tests/test_aptd.py'
--- tests/test_aptd.py	2012-09-18 09:21:16 +0000
+++ tests/test_aptd.py	2012-10-05 08:53:20 +0000
@@ -24,7 +24,7 @@
 from defer import inline_callbacks
 from mock import Mock, patch
 
-import aptdaemon.loop
+import aptdaemon
 
 
 class TestAptdaemon(unittest.TestCase):
@@ -169,6 +169,13 @@
             kwargs["input"].split("\0"),
             [ 'DialogBody', 'msg','Traceback', 'traceback-error'])
 
+    def test_ignore_bad_packages(self):
+        mock_trans = Mock(aptdaemon.client.AptTransaction)
+        mock_trans.error_code = aptdaemon.enums.ERROR_INVALID_PACKAGE_FILE
+        with patch.object(self.aptd, "_call_apport_recoverable_error") as m:
+            self.aptd._on_trans_error("some error", mock_trans)
+            self.assertFalse(m.called)
+
 
 if __name__ == "__main__":
     logging.basicConfig(level=logging.INFO)