Merge lp:~mvo/software-center/lp1005104 into lp:software-center

Proposed by Michael Vogt on 2012-05-30
Status: Merged
Merge reported by: Gary Lasker
Merged at revision: not available
Proposed branch: lp:~mvo/software-center/lp1005104
Merge into: lp:software-center
Diff against target: 16 lines (+6/-0)
1 file modified
softwarecenter/ui/gtk3/panes/ (+6/-0)
To merge this branch: bzr merge lp:~mvo/software-center/lp1005104
Reviewer Review Type Date Requested Status
Gary Lasker (community) 2012-05-30 Approve on 2012-05-30
Review via email:

Description of the change

This fixes a regression introduced in r3006 that causes the initial click on a app to now show
up in the navigation history. The visible effect is that the back-button does not get sensitive
when clicking on a banner item or on a app in "whats new".

To post a comment you must log in.
Gary Lasker (gary-lasker) wrote :

This looks fine, thank you, Michael!

review: Approve
Gary Lasker (gary-lasker) wrote :

Merged to the 5.2 branch now.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2=== modified file 'softwarecenter/ui/gtk3/panes/'
3--- softwarecenter/ui/gtk3/panes/ 2012-05-17 12:27:58 +0000
4+++ softwarecenter/ui/gtk3/panes/ 2012-05-30 12:44:18 +0000
5@@ -236,6 +236,12 @@
6 # again (LP: #851671)
7 self.view_initialized = True
9+ # important to "seed" the initial history stack (LP: #1005104)
10+ vm = get_viewmanager()
11+ vm.display_page(
12+ self, AvailablePane.Pages.LOBBY,
13+ self.state, self.display_lobby_page)
15 if window is not None:
16 window.set_cursor(None)


People subscribed via source and target branches