Merge lp:~mvo/software-center/lobby-recommends-fixes into lp:software-center
Proposed by
Michael Vogt
Status: | Merged |
---|---|
Merged at revision: | 2800 |
Proposed branch: | lp:~mvo/software-center/lobby-recommends-fixes |
Merge into: | lp:software-center |
Diff against target: |
178 lines (+75/-14) 4 files modified
softwarecenter/testutils.py (+1/-1) softwarecenter/ui/gtk3/widgets/recommendations.py (+29/-7) test/gtk3/test_catview.py (+15/-6) test/gtk3/test_recommendations_widgets.py (+30/-0) |
To merge this branch: | bzr merge lp:~mvo/software-center/lobby-recommends-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gary Lasker (community) | Approve | ||
Review via email: mp+95331@code.launchpad.net |
Description of the change
Add missing test and some cleanup (avoid duplicated entries if the agent is ever asked again for recommendations).
To post a comment you must log in.
Looks great, thanks mvo! I've merged your branch back into lp:~gary-lasker/software-center/lobby-recommends-fixes (see https:/ /code.launchpad .net/~gary- lasker/ software- center/ lobby-recommend s-fixes/ +merge/ 95296) and I ran all unit tests and they pass. I think if we merge https:/ /code.launchpad .net/~gary- lasker/ software- center/ lobby-recommend s-fixes/ +merge/ 95296 now we will be ready to go for a release today. All of the recommends stuff appears to work fine.
Thanks!