Merge lp:~mvo/software-center/installed-view-speedup into lp:software-center

[Michael Vogt]

Small branch that removes a unused notebook that causes massive slowdown in the startup when
calling with a already installed package. Speedup for me is from 34s to 3s until the details
are visible (hot cache!).

[Gary Lasker (gary-lasker)]

Definitely don't need that extra notebook! Seems weird that that was left in!

One thing though, on my machine I can't seem to see the speedup you are observing. I am opening a deb for a package that I already have installed, but it doesn't seem appreciably faster after the merge. I suspect I am not checking the correct thing? Could you give a quick test case so I can make sure. Thanks!

In any case, it's definitely a nice piece of cleanup and I will merge it now. Thanks mvo!!

review: Approve

[Michael Vogt (mvo)]

On Wed, Feb 29, 2012 at 07:16:16AM -0000, Gary Lasker wrote:
> Review: Approve
>
> Definitely don't need that extra notebook! Seems weird that that was left in!

Great, thanks for double checking.

> One thing though, on my machine I can't seem to see the speedup you are observing. I am opening a deb for a package that I already have installed, but it doesn't seem appreciably faster after the merge. I suspect I am not checking the correct thing? Could you give a quick test case so I can make sure. Thanks!

Sure, so I did: "software-center apt" and waited until that was
displayed in the details view. That took a long time before and got
much quicker with the removal of the extra notebook.

> In any case, it's definitely a nice piece of cleanup and I will merge it now. Thanks mvo!!

Thanks for the merge.

Cheers,
 Michael

[Gary Lasker (gary-lasker)]

Ahh, ok! I can see the speedup now, and indeed, it is dramatic!! Nice. :D

=== modified file 'softwarecenter/ui/gtk3/app.py'
--- softwarecenter/ui/gtk3/app.py	2012-02-16 14:17:38 +0000
+++ softwarecenter/ui/gtk3/app.py	2012-02-28 14:04:20 +0000
@@ -1175,8 +1175,10 @@
                 # if the pkg is installed, show it in the installed pane
                 if (app.pkgname in self.cache and 
                     self.cache[app.pkgname].installed):
-                    self.installed_pane.init_view()
-                    self.installed_pane.show_app(app)
+                    with ExecutionTime("installed_pane.init_view()"):
+                        self.installed_pane.init_view()
+                    with ExecutionTime("installed_pane.show_app()"):
+                        self.installed_pane.show_app(app)
                 else:
                     self.available_pane.init_view()
                     self.available_pane.show_app(app)

=== modified file 'softwarecenter/ui/gtk3/panes/softwarepane.py'
--- softwarecenter/ui/gtk3/panes/softwarepane.py	2012-02-16 14:14:01 +0000
+++ softwarecenter/ui/gtk3/panes/softwarepane.py	2012-02-28 14:04:20 +0000
@@ -179,17 +179,16 @@
         if not "SOFTWARE_CENTER_DEBUG_TABS" in os.environ:
             self.notebook.set_show_tabs(False)
         self.notebook.set_show_border(False)
-        # an empty notebook, where the details view will eventually go
-        self.details_notebook = Gtk.Notebook()
-        self.details_notebook.set_show_border(False)
         # make a spinner view to display while the applist is loading
         self.spinner_view = SpinnerView()
         self.spinner_notebook = Gtk.Notebook()
-        self.spinner_notebook.set_show_tabs(False)
+        if not "SOFTWARE_CENTER_DEBUG_TABS" in os.environ:
+            self.spinner_notebook.set_show_tabs(False)
         self.spinner_notebook.set_show_border(False)
-        self.spinner_notebook.append_page(self.notebook, None)
-        self.spinner_notebook.append_page(self.details_notebook, None)
-        self.spinner_notebook.append_page(self.spinner_view, None)
+        self.spinner_notebook.append_page(self.notebook, 
+                                          Gtk.Label("view"))
+        self.spinner_notebook.append_page(self.spinner_view, 
+                                          Gtk.Label("spinner"))
         
         self.pack_start(self.spinner_notebook, True, True, 0)