Merge lp:~mvo/software-center/fix-lp870847-5.2 into lp:software-center/5.2

Proposed by Michael Vogt on 2012-08-17
Status: Merged
Merged at revision: 3072
Proposed branch: lp:~mvo/software-center/fix-lp870847-5.2
Merge into: lp:software-center/5.2
Diff against target: 12 lines (+1/-1)
1 file modified
softwarecenter/backend/piston/rnrclient_pristine.py (+1/-1)
To merge this branch: bzr merge lp:~mvo/software-center/fix-lp870847-5.2
Reviewer Review Type Date Requested Status
Gary Lasker (community) 2012-08-17 Approve on 2012-08-18
Review via email: mp+120092@code.launchpad.net

Description of the change

This branch fixes the problem that its impossible to modify reviews
currently AFAICT.

This branch merges cleanly in both 5.2 and trunk, see also lp:~mvo/rnr-server/rnrclient-fix-lp870847 for diff targeted to the "upstream" branch.

To post a comment you must log in.
Gary Lasker (gary-lasker) wrote :

Nice, simple fix! Thanks mvo.

I will merge to both branches.

review: Approve
Gary Lasker (gary-lasker) wrote :

Never mind, I just noticed that it's already in trunk and has been released!

Merging to the 5.2 branch.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/backend/piston/rnrclient_pristine.py'
2--- softwarecenter/backend/piston/rnrclient_pristine.py 2012-03-16 20:12:57 +0000
3+++ softwarecenter/backend/piston/rnrclient_pristine.py 2012-08-17 09:36:20 +0000
4@@ -180,7 +180,7 @@
5 @validate('review_id', int)
6 @validate('rating', int)
7 @validate_pattern('summary', r'[^\n]+')
8- @validate_pattern('review_text', r'[^\n]+')
9+ @validate('review_text', str)
10 @returns(ReviewDetails)
11 def modify_review(self, review_id, rating, summary, review_text):
12 """Modify an existing review"""

Subscribers

People subscribed via source and target branches