Ubuntu Software Center

Merge lp:~mvo/software-center/fix-get-set-gobject-data into lp:software-center

  1. fix-get-set-gobject-data
  2. Merge into trunk
Proposed by Michael Vogt
Status: Merged
Merged at revision: 3062
Proposed branch: lp:~mvo/software-center/fix-get-set-gobject-data
Merge into: lp:software-center
Diff against target: 21 lines (+2/-2)
1 file modified
softwarecenter/ui/gtk3/views/purchaseview.py (+2/-2)
To merge this branch: bzr merge lp:~mvo/software-center/fix-get-set-gobject-data
Reviewer Review Type Date Requested Status
Gary Lasker (community) Approve
Review via email: mp+112503@code.launchpad.net

Description of the change

Trivial branch that fixes a leftover use of "GObject.{get,set}_data()" that is no longer supported by python-gi in quantal.

To post a comment you must log in.
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Looks fine, thanks mvo!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/ui/gtk3/views/purchaseview.py'
2--- softwarecenter/ui/gtk3/views/purchaseview.py 2012-05-30 18:39:55 +0000
3+++ softwarecenter/ui/gtk3/views/purchaseview.py 2012-06-28 07:28:21 +0000
4@@ -182,7 +182,7 @@
5 return True
6
7 def _on_close_web_view(self, view):
8- win = view.get_data("win")
9+ win = view.parent_win
10 win.destroy()
11 return True
12
13@@ -194,7 +194,7 @@
14 win.add(wk)
15 win.show_all()
16 # make sure close will work later
17- wk.webkit.set_data("win", win)
18+ wk.webkit.parent_win = win
19 # find and set parent
20 w = self.wk.get_parent()
21 while w.get_parent():

Subscribers

People subscribed via source and target branches