Ubuntu Software Center

Merge lp:~mvo/software-center/fix-crash-1048886 into lp:software-center

  1. fix-crash-1048886
  2. Merge into trunk
Proposed by Michael Vogt
Status: Merged
Merged at revision: 3216
Proposed branch: lp:~mvo/software-center/fix-crash-1048886
Merge into: lp:software-center
Diff against target: 14 lines (+0/-4)
1 file modified
utils/submit_review_gtk3.py (+0/-4)
To merge this branch: bzr merge lp:~mvo/software-center/fix-crash-1048886
Reviewer Review Type Date Requested Status
Gary Lasker (community) Approve
Albert Astals Cid (community) Approve
Review via email: mp+128050@code.launchpad.net

Commit message

No longer call GLib.init_threads() as this will cause LP: #1048886 later. Many thanks to Albert Astals Cid

Description of the change

This fixes a crash when trying to write a review. It appears to be a pygi
issue and fixes bug #1048886 (instructions how to reproduce are in the
bugreport).

Many thanks to Albert Astals Cid for helping to track this down.

To post a comment you must log in.
Revision history for this message
Albert Astals Cid (aacid) wrote :

Works for me!

review: Approve
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Thanks very much, Albert! And thanks mvo! Merging now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'utils/submit_review_gtk3.py'
2--- utils/submit_review_gtk3.py 2012-03-15 10:43:13 +0000
3+++ utils/submit_review_gtk3.py 2012-10-04 15:55:27 +0000
4@@ -45,10 +45,6 @@
5 #import httplib2
6 #httplib2.debuglevel = 1
7
8-# the glib docs tell us that this is no longer needed, but if its omited
9-# the system will hang on submit *sigh*
10-from gi.repository import GLib
11-GLib.threads_init()
12
13 if __name__ == "__main__":
14 try:

Subscribers

People subscribed via source and target branches