Merge lp:~mvo/software-center/drive-by-update-terms into lp:software-center

Proposed by Michael Vogt
Status: Merged
Merged at revision: 3121
Proposed branch: lp:~mvo/software-center/drive-by-update-terms
Merge into: lp:software-center
Diff against target: 0 lines
To merge this branch: bzr merge lp:~mvo/software-center/drive-by-update-terms
Reviewer Review Type Date Requested Status
James Westby (community) Approve
software-store-developers Pending
Review via email: mp+120721@code.launchpad.net

Description of the change

A tiny change to make the update.py code more data driven, i.e. make
it easier to add new field for the origins later if we need them

To post a comment you must log in.
3120. By Michael Vogt

softwarecenter/db/update.py: trivial pep8 fix

Revision history for this message
James Westby (james-w) wrote :

29 + for (term, attr) in self.ORIGINS_TO_TERMS.iteritems():

.iteritems() isn't available in py3 (it's spelled .items())

Given that your dict is small I don't think having a list is
a problem, so I'd suggest using .items() to make porting that
little bit easier.

Thanks,

James

review: Approve
3121. By Michael Vogt

softwarecenter/db/update.py: use dict.items() instead of dict.iteritems() as the later is not available in py3

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks a lot for the review James, I fixed this now.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches