Merge lp:~mvo/software-center/cookie-jar into lp:software-center/5.2

Proposed by Michael Vogt on 2012-06-27
Status: Merged
Approved by: Michael Nelson on 2012-06-28
Approved revision: 3054
Merged at revision: 3053
Proposed branch: lp:~mvo/software-center/cookie-jar
Merge into: lp:software-center/5.2
Diff against target: 0 lines
To merge this branch: bzr merge lp:~mvo/software-center/cookie-jar
Reviewer Review Type Date Requested Status
Michael Nelson 2012-06-27 Approve on 2012-06-28
Review via email: mp+112418@code.launchpad.net

Description of the change

This branch adds a persistent cookie jar to software-center. This fixes the currently not working paypal method.

To test:
- open software-center
- try to purchase a app
- select paypal as the purchase method
- verify that the screen goes gray but no window opens and there is a error message on the terminal

this branch fixes the last problem. Bug reference #1018347

To post a comment you must log in.
lp:~mvo/software-center/cookie-jar updated on 2012-06-28
3054. By Michael Vogt on 2012-06-28

softwarecenter/ui/gtk3/views/webkit.py: refresh the cookies.txt on each session until we have a logout button on the webpage

Michael Nelson (michael.nelson) wrote :

Great work finding a solution so quickly mvo. I'm guessing you'll be able to add a related test for the trunk version.

08:18 < mvo> could someone do a s-c review for me? https://code.launchpad.net/~mvo/software-center/cookie-jar/+merge/112418 it unbreaks paypal so I would like to get it out of the door this morning
08:19 < noodles> mvo: did you reply to ricardo's comment on the bug?
08:19 * noodles checks
08:19 < mvo> I did
08:20 < noodles> mvo: but wouldn't there need to be a logout somewhere on USC itself? (or, how do people get to the pay page where the order summary is from within USC's embedded browser?)
08:21 < noodles> mvo: Ah, you're clearing the cookies on each start?
08:21 < noodles> Sweet.
08:21 < noodles> Approving.
08:22 < mvo> noodles: I don't know :) I mean, it might be that USC would have to offer this, but I don't know what it would have to do, go to a special page to logout? clear some special cookies? happy to work on this once I know what pay needs but that is probably trunk material
08:22 < mvo> thanks a lot noodles, the removal is a bit of a heavy handed approach, but its not a regression, before we had no cookies at all
08:22 < noodles> Yep.

review: Approve
Michael Vogt (mvo) wrote :

Thanks noodles, yeah, good point about the test. I added one now.

lp:~mvo/software-center/cookie-jar updated on 2012-06-28
3055. By Michael Vogt on 2012-06-28

test/gtk3/test_purchase.py: add test to ensure we have the cookie jar available

Preview Diff

Empty

Subscribers

People subscribed via source and target branches