Code review comment for lp:~mvo/software-center/app-treeview-buy-plus-refactor

Revision history for this message
Gary Lasker (gary-lasker) wrote :

This all looks great. All tests pass for me as well, and I tried out the new capabilities myself in various views, etc., some corner cases like canceling purchases and such, and everything works as I expected. Very nice!

The only thing that I wonder is whether we might want to move the location of the price in the list view. It seems like we have consolidated the useful info about an app to the left-hand side, and to me it feels like the price should be there too. But, that's something we can think about (and check with mpt too) and it would be an easy thing to tweak later. So, I'll mark this one approved and I'll merge it now.

Thanks so much! Very nice work, Matt and mvo!

review: Approve

« Back to merge proposal