Merge lp:~mvo/snappy/snappy-merge-integration-tests into lp:~snappy-dev/snappy/snappy-moved-to-github
| Status: | Merged |
|---|---|
| Approved by: | Leo Arias on 2015-06-09 |
| Approved revision: | 468 |
| Merged at revision: | 499 |
| Proposed branch: | lp:~mvo/snappy/snappy-merge-integration-tests |
| Merge into: | lp:~snappy-dev/snappy/snappy-moved-to-github |
| Diff against target: |
599 lines (+483/-0) 21 files modified
integration-tests/run-in-image/README (+16/-0) integration-tests/run-in-image/debian/tests/control (+2/-0) integration-tests/run-in-image/snappy-selftest (+51/-0) integration-tests/run-in-image/tests/01_test_info (+4/-0) integration-tests/run-in-image/tests/02_test_versions (+7/-0) integration-tests/run-in-image/tests/03_test_apt (+4/-0) integration-tests/run-in-image/tests/04_test_install_hello (+7/-0) integration-tests/run-in-image/tests/05_test_install_nonexistant (+5/-0) integration-tests/run-in-image/tests/06_test_search_framework (+4/-0) integration-tests/run-in-image/tests/07_test_install_framework (+33/-0) integration-tests/run-in-image/tests/08_test_versions_has_framework (+4/-0) integration-tests/run-in-image/tests/10_test_info_has_stuff (+5/-0) integration-tests/run-in-image/tests/11_test_xkcd_listens (+15/-0) integration-tests/run-in-image/tests/80_test_failover (+48/-0) integration-tests/run-in-image/tests/90_test_upgrade (+45/-0) integration-tests/run-in-image/tests/91_test_upgrade_from_stable_image (+51/-0) integration-tests/run-in-image/tests/common.sh (+59/-0) integration-tests/run-in-image/tests/framework (+46/-0) integration-tests/run-in-image/tests/settings (+3/-0) integration-tests/selftest (+68/-0) run-checks (+6/-0) |
| To merge this branch: | bzr merge lp:~mvo/snappy/snappy-merge-integration-tests |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Leo Arias | 2015-05-20 | Approve on 2015-06-09 | |
| Sergio Schvezov | Needs Information on 2015-05-21 | ||
| John Lenton | 2015-05-20 | Approve on 2015-05-20 | |
| Martin Pitt | 2015-05-20 | Pending | |
|
Review via email:
|
|||
Commit Message
Integrate lp:snappy/selftest branch into snappy itself
Description of the Change
This branch integrates the lp:snappy/selftest branch into snappy itself and provides support for running the integration tests as part of the run-checks.sh command.
The way this works is essentially:
- build a deb package from the current tree
- build a fresh ubuntu core test image
- copy/install the ubuntu-snappy deb package into the new image
- run the integration-tests inside this new image via "autopkgtest"
This should allow us to run the full testsuite for each MP via tarmac.
Some open questions:
- can we avoid using sudo for the ubuntu-device-flash generation of the image somehow?
- what does need to change on the CI side so that the new way of running the tests is supported?
- can we add that to our tarmac infrastructure somehow?
| Sergio Schvezov (sergiusens) wrote : | # |
> drooling at running this in tarmac, here. When can we drop kpartx? (aiui
> that's where the need for sudo comes from)
Can you think of anything that doesn't require something similar to kpartx?
I can think of having an option for split image files, but you would still need sudo to install grub, unless more people get on board the idea of using a grub img file (dd'ed ala u-boot) and all the other stuff that goes on.
| Sergio Schvezov (sergiusens) wrote : | # |
hmm, we also want to disable the autopilot; one way of doing this is to create an oem package with a config for it to be disabled by default.
| Leo Arias (elopio) wrote : | # |
All good, what could possibly go wrong
\o/
The tests pass. That's an awesome start for me.
I would like to see the tests running from debian/
16 +++ integration-
Do you think it is not a good idea to get them running during proposed-migration?
| Sergio Schvezov (sergiusens) wrote : | # |
On Thu, May 21, 2015 at 09:30:57PM -0000, Leo Arias wrote:
> All good, what could possibly go wrong
>
> \o/
>
> The tests pass. That's an awesome start for me.
> I would like to see the tests running from debian/
>
> 16 +++ integration-
Won't this be tricky since it requires an internet connection?
> Do you think it is not a good idea to get them running during proposed-migration?
That's being worked on by the ci team already.
- 466. By Michael Vogt on 2015-05-22
-
sync with lp:snappy/selftest
| Leo Arias (elopio) wrote : | # |
> On Thu, May 21, 2015 at 09:30:57PM -0000, Leo Arias wrote:
> > All good, what could possibly go wrong
> >
> > \o/
> >
> > The tests pass. That's an awesome start for me.
> > I would like to see the tests running from debian/
> >
> > 16 +++ integration-
>
> Won't this be tricky since it requires an internet connection?
Yes, we would need to deploy a local fake server that replies with the right messages. Then the tests will be able to run with the fake when there's no internet, or with the real server when there is. If CI is going to run the suite against the real server often enough, probably there's no need for the fake.
| Federico Gimenez (fgimenez) wrote : | # |
Looks great, some inline comments.
Thanks!
- 467. By Michael Vogt on 2015-06-09
-
merged lp:snappy
- 468. By Michael Vogt on 2015-06-09
-
do not try to sign the deb
| Leo Arias (elopio) wrote : | # |
Successful run: http://
Thanks mvo.
pitti is right, of course. We need to figure out how to generate an image that contains snappy from the code of the branch.
So lets land this and iterate.
| Ricardo Salveti (rsalveti) wrote : | # |
From IRC:
<rsalveti> elopio: so, ideally the way to change the image is basically as pitti said, which is creating another clean image with livecd-rootfs
<rsalveti> elopio: the proposed-migration work that the ci team is doing basically that, but using launchpad to build the new image
<rsalveti> we should just have a script or something that can easily do that locally (something like rootstock, ogra_ ^^)
<rsalveti> elopio: we definitely don't want to change the image by installing debs in runtime, as that's not the same path used when we produce the final images
<ogra_> i can look into making rootstock work for core


drooling at running this in tarmac, here. When can we drop kpartx? (aiui that's where the need for sudo comes from)