Merge lp:~mvo/snappy-hub/docker into lp:~snappy-dev/snappy-hub/docker

Proposed by Michael Vogt
Status: Needs review
Proposed branch: lp:~mvo/snappy-hub/docker
Merge into: lp:~snappy-dev/snappy-hub/docker
Diff against target: 195 lines (+64/-52)
5 files modified
package-dir/bin/docker-privilege (+1/-1)
package-dir/meta/docker-daemon.apparmor (+10/-10)
package-dir/meta/docker-privilege.apparmor (+11/-11)
package-dir/meta/readme.md (+0/-20)
package-dir/meta/snap.yaml (+42/-10)
To merge this branch: bzr merge lp:~mvo/snappy-hub/docker
Reviewer Review Type Date Requested Status
Snappy Developers Pending
Review via email: mp+283998@code.launchpad.net

Description of the change

Move to the new snap.yaml syntax

To post a comment you must log in.
lp:~mvo/snappy-hub/docker updated
41. By Michael Vogt

updated for the new interfaces syntax

42. By Michael Vogt

slot->plug, plug->slot

Unmerged revisions

42. By Michael Vogt

slot->plug, plug->slot

41. By Michael Vogt

updated for the new interfaces syntax

40. By Michael Vogt

Move to new snap.yaml

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'package-dir/bin/docker-privilege'
2--- package-dir/bin/docker-privilege 2015-08-11 14:04:55 +0000
3+++ package-dir/bin/docker-privilege 2016-03-04 11:27:14 +0000
4@@ -1,7 +1,7 @@
5 #!/bin/bash
6
7 snappy_err () {
8- echo "This script needs to be run under snappy wrapper (/apps/bin)"
9+ echo "This script needs to be run under snappy wrapper (/snaps/bin)"
10 exit 1
11 }
12
13
14=== modified file 'package-dir/meta/docker-daemon.apparmor'
15--- package-dir/meta/docker-daemon.apparmor 2015-10-09 14:57:33 +0000
16+++ package-dir/meta/docker-daemon.apparmor 2016-03-04 11:27:14 +0000
17@@ -25,8 +25,8 @@
18 # FIXME: app upgrades don't perform migration yet. When they do, remove
19 # these two rules and update package-dir/bin/docker.wrap as per its comments.
20 # See: https://app.asana.com/0/21120773903349/21160815722783
21- /var/lib/apps/@{APP_PKGNAME}/ w,
22- /var/lib/apps/@{APP_PKGNAME}/** wl,
23+ /var/lib/snaps/@{APP_PKGNAME}/ w,
24+ /var/lib/snaps/@{APP_PKGNAME}/** wl,
25
26 # Read-only for the install directory
27 @{CLICK_DIR}/@{APP_PKGNAME}/ r,
28@@ -34,21 +34,21 @@
29 @{CLICK_DIR}/@{APP_PKGNAME}/@{APP_VERSION}/** mrklix,
30
31 # Writable home area
32- @{HOMEDIRS}/*/apps/@{APP_PKGNAME}/ rw,
33- @{HOMEDIRS}/*/apps/@{APP_PKGNAME}/** mrwklix,
34+ @{HOMEDIRS}/*/snaps/@{APP_PKGNAME}/ rw,
35+ @{HOMEDIRS}/*/snaps/@{APP_PKGNAME}/** mrwklix,
36
37 # Read-only system area for other versions
38- /var/lib/apps/@{APP_PKGNAME}/ r,
39- /var/lib/apps/@{APP_PKGNAME}/** mrkix,
40+ /var/lib/snaps/@{APP_PKGNAME}/ r,
41+ /var/lib/snaps/@{APP_PKGNAME}/** mrkix,
42
43- # TODO: the write on /var/lib/apps/@{APP_PKGNAME}/ is needed in case it
44+ # TODO: the write on /var/lib/snaps/@{APP_PKGNAME}/ is needed in case it
45 # doesn't exist, but means an app could adjust inode data and affect
46 # rollbacks.
47- /var/lib/apps/@{APP_PKGNAME}/ w,
48+ /var/lib/snaps/@{APP_PKGNAME}/ w,
49
50 # Writable system area only for this version.
51- /var/lib/apps/@{APP_PKGNAME}/@{APP_VERSION}/ w,
52- /var/lib/apps/@{APP_PKGNAME}/@{APP_VERSION}/** wl,
53+ /var/lib/snaps/@{APP_PKGNAME}/@{APP_VERSION}/ w,
54+ /var/lib/snaps/@{APP_PKGNAME}/@{APP_VERSION}/** wl,
55
56 /writable/cache/docker/ rw,
57 /writable/cache/docker/** mrwklix,
58
59=== modified file 'package-dir/meta/docker-privilege.apparmor'
60--- package-dir/meta/docker-privilege.apparmor 2015-04-15 12:28:05 +0000
61+++ package-dir/meta/docker-privilege.apparmor 2016-03-04 11:27:14 +0000
62@@ -133,26 +133,26 @@
63 @{CLICK_DIR}/@{APP_PKGNAME}/@{APP_VERSION}/** mrklix,
64
65 # Read-only home area for other versions
66- owner @{HOMEDIRS}/*/apps/@{APP_PKGNAME}/ r,
67- owner @{HOMEDIRS}/*/apps/@{APP_PKGNAME}/@{APP_VERSION}/ r,
68- owner @{HOMEDIRS}/*/apps/@{APP_PKGNAME}/@{APP_VERSION}/** mrkix,
69+ owner @{HOMEDIRS}/*/snaps/@{APP_PKGNAME}/ r,
70+ owner @{HOMEDIRS}/*/snaps/@{APP_PKGNAME}/@{APP_VERSION}/ r,
71+ owner @{HOMEDIRS}/*/snaps/@{APP_PKGNAME}/@{APP_VERSION}/** mrkix,
72
73 # Writable home area for this version.
74- owner @{HOMEDIRS}/*/apps/@{APP_PKGNAME}/@{APP_VERSION}/ w,
75- owner @{HOMEDIRS}/*/apps/@{APP_PKGNAME}/@{APP_VERSION}/** wl,
76+ owner @{HOMEDIRS}/*/snaps/@{APP_PKGNAME}/@{APP_VERSION}/ w,
77+ owner @{HOMEDIRS}/*/snaps/@{APP_PKGNAME}/@{APP_VERSION}/** wl,
78
79 # Read-only system area for other versions
80- /var/lib/apps/@{APP_PKGNAME}/ r,
81- /var/lib/apps/@{APP_PKGNAME}/** mrkix,
82+ /var/lib/snaps/@{APP_PKGNAME}/ r,
83+ /var/lib/snaps/@{APP_PKGNAME}/** mrkix,
84
85 # TODO: the write on these is needed in case they doesn't exist, but means an
86 # app could adjust inode data and affect rollbacks.
87- owner @{HOMEDIRS}/*/apps/@{APP_PKGNAME}/ w,
88- /var/lib/apps/@{APP_PKGNAME}/ w,
89+ owner @{HOMEDIRS}/*/snaps/@{APP_PKGNAME}/ w,
90+ /var/lib/snaps/@{APP_PKGNAME}/ w,
91
92 # Writable system area only for this version
93- /var/lib/apps/@{APP_PKGNAME}/@{APP_VERSION}/ w,
94- /var/lib/apps/@{APP_PKGNAME}/@{APP_VERSION}/** wl,
95+ /var/lib/snaps/@{APP_PKGNAME}/@{APP_VERSION}/ w,
96+ /var/lib/snaps/@{APP_PKGNAME}/@{APP_VERSION}/** wl,
97
98 # Writable temp area only for this version (launcher will create this
99 # directory on our behalf so only allow readonly on parent). /tmp/snapps can
100
101=== renamed file 'package-dir/meta/docker.svg' => 'package-dir/meta/icon.svg'
102=== removed file 'package-dir/meta/readme.md'
103--- package-dir/meta/readme.md 2015-08-11 14:04:55 +0000
104+++ package-dir/meta/readme.md 1970-01-01 00:00:00 +0000
105@@ -1,20 +0,0 @@
106-Docker Framework
107-This is the docker app deployment mechanism.
108-
109-Actual docker version: 1.6.2
110-
111-Apparmor profiles have been moved to /var/lib/apparmor/profiles, default profile as been modified.
112-Data is stored in /var/lib/apps/docker/${version_of_snap_package}/.
113-
114-If you need to pass through proxies or dns, edit /apps/docker/current/etc/docker.conf accordingly and restart the docker service:
115-i.e:
116-FTP_PROXY=http://your.proxy:3128
117-HTTP_PROXY=http://your.proxy:3128
118-HTTPS_PROXY=http://your.proxy:3128
119-DOCKER_OPTIONS="--dns 8.8.8.8"
120-
121-If you need privileged access, you can issue 'docker-privilege on'. But the confinment will be nearly inexistant.
122-
123-Docker can read and write to your home/apps/docker/** directory, place your Dockerfile, there.
124-
125-sudo systemctl restart docker_docker_${version_of_snap_package}.service
126
127=== renamed file 'package-dir/meta/package.yaml' => 'package-dir/meta/snap.yaml'
128--- package-dir/meta/package.yaml 2015-11-13 16:04:00 +0000
129+++ package-dir/meta/snap.yaml 2016-03-04 11:27:14 +0000
130@@ -1,23 +1,55 @@
131 name: docker
132-version: 1.6.2.005
133-architectures: [amd64, armhf]
134-icon: meta/docker.svg
135-vendor: Pierre-Andre MOREY <pierre-andre.morey@canonical.com>
136+version: 1.6.2.005-16.04.1-2
137+summary: Docker Framework
138+description: |
139+ This is the docker app deployment mechanism.
140+
141+ Actual docker version: 1.6.2
142+
143+ Apparmor profiles have been moved to /var/lib/apparmor/profiles, default profile as been modified.
144+ Data is stored in /var/lib/snaps/docker/${version_of_snap_package}/.
145+
146+ If you need to pass through proxies or dns, edit /snaps/docker/current/etc/docker.conf accordingly and restart the docker service:
147+i.e:
148+ FTP_PROXY=http://your.proxy:3128
149+ HTTP_PROXY=http://your.proxy:3128
150+ HTTPS_PROXY=http://your.proxy:3128
151+ DOCKER_OPTIONS="--dns 8.8.8.8"
152+
153+ If you need privileged access, you can issue 'docker-privilege on'. But the confinment will be nearly inexistant.
154+
155+ Docker can read and write to your home/snaps/docker/** directory, place your Dockerfile, there.
156+
157+ sudo systemctl restart docker_docker_${version_of_snap_package}.service
158+architecture: [amd64, armhf]
159 type: framework
160-services:
161- - name: docker-daemon
162+apps:
163+ docker-daemon:
164+ command: docker-daemon
165+ daemon: simple
166 description: The docker app deployment mechanism
167- start: bin/docker.start
168+ command: bin/docker.start
169 stop: bin/docker.stop
170+ plugs: [docker-daemon]
171+ docker:
172+ command: bin/docker
173+ plugs: [docker]
174+ docker-privilege:
175+ command: bin/docker-privilege
176+ plugs: [docker-privilege]
177+plugs:
178+ docker-daemon:
179+ interface: old-security
180 security-policy:
181 apparmor: meta/docker-daemon.apparmor
182 seccomp: meta/docker-daemon.seccomp
183-binaries:
184- - name: bin/docker
185+ docker:
186+ interface: old-security
187 caps:
188 - docker_client
189 - network-client
190- - name: bin/docker-privilege
191+ docker-privilege:
192+ interface: old-security
193 security-policy:
194 apparmor: meta/docker-privilege.apparmor
195 seccomp: meta/docker-privilege.seccomp

Subscribers

People subscribed via source and target branches