~mvo/snapd/+git/snapd-mvo:core18-proxy-2

Last commit made on 2019-12-06
Get this branch:
git clone -b core18-proxy-2 https://git.launchpad.net/~mvo/snapd/+git/snapd-mvo

Branch merges

Branch information

Name:
core18-proxy-2
Repository:
lp:~mvo/snapd/+git/snapd-mvo

Recent commits

9dc7987... by Sergio Cazzolato

Merge remote-tracking branch 'upstream/master' into core18-proxy-2

b1bff80... by Paweł Stołowski

Merge pull request #7859 from stolowski/disable-mount-ns-test

tests: disable mount-ns test on 16.04 for now

5cedb8d... by Paweł Stołowski

Disable mount-ns test on 16.04 for now until ns changes are fixed.

bd9c677... by Maciej Borzecki

Merge pull request #7846 from mvo5/core20-devicemgr-install-2.1

devicestate: add missing test for failing task setup-run-system

c464f86... by Sergio Cazzolato

Use a dummy rsyslog service when it does not exist in the core system

This is mainly for core18

9a78b4d... by Claudio Matsuoka

Merge pull request #7835 from mvo5/gadget-validate-missing-duplicate-test

gadget: add missing test for duplicate detection of roles

eeff8f7... by Ian Johnson

Merge pull request #7843 from anonymouse64/bugfix/test-snapctl-help-context-env

tests/cmd/snapctl: unset SNAP_CONTEXT for the suite

This test specifically would fail when go was run from a snap, because snap-confine for the go snap would set SNAP_COOKIE from here:

https://github.com/snapcore/snapd/blob/9b212f0a9f5afb81ab28db632807c9402a69b780/cmd/snap-confine/snap-confine.c#L462-L463

which would then cause snapctl to pick up the SNAP_CONTEXT variable and not see that the SNAP_COOKIE variable is unset and show a help message. So if we unset this environment variable when running this test suite, we are protected against this possibility.

For reference, the test would fail like this:

```
----------------------------------------------------------------------
FAIL: main_test.go:108: snapctlSuite.TestSnapctlHelp

main_test.go:61:
    c.Assert(snapctlOptions.ContextID, Equals, s.expectedContextID)
... obtained string = "dFPq0qs83PLy2tHK5YmFVss3v1V6yVGvjwDhwp1H80yD"
... expected string = ""

main_test.go:117:
    c.Check(err, IsNil)
... value client.ConnectionError = client.ConnectionError{Err:(*url.Error)(0xc0000206c0)} ("cannot communicate with server: Post http://127.0.0.1:34175/v2/snapctl: EOF")

OOPS: 2 passed, 1 FAILED
--- FAIL: TestT (0.05s)
FAIL
```

4c562a1... by "John R. Lenton" <email address hidden>

Merge pull request #7320 from chipaca/check-skeleton-check-interfaces

snap/pack, cmd_pack: 'snap pack --check-skeleton' checks interfaces

9b212f0... by Paweł Stołowski

Merge pull request #7844 from sd-hd/_gitignore

gitignore: ignore visual studio code directory

c89b4c6... by Michael Vogt

Merge pull request #7823 from mvo5/cmd-snap-bootstrap-run-mode

snap-bootstrap: implement "run" mode in snap-bootstrap initramfs-mounts