Merge lp:~mvo/sessioninstaller/install-provided-for-binaries into lp:sessioninstaller

[Michael Vogt]

This should give us "install_provided_file" support for binaries.

I just tested it with brasero and it works fine there, it requests cdrdao
and after the install is finished, it will burn the disk.

[Michael Vogt (mvo)]

A full fix needs apt-file I think. We should monitor how this is actually used, if e.g.
for libs, we could extend command-not-found to include them too.

=== modified file 'sessioninstaller/core.py'
--- sessioninstaller/core.py	2010-09-09 07:02:33 +0000
+++ sessioninstaller/core.py	2010-09-20 10:11:03 +0000
@@ -685,6 +685,25 @@
     @track_usage
     @inline_callbacks
     def _install_provide_files(self, xid, files, interaction, sender):
+        try:
+            import CommandNotFound
+            cnf = CommandNotFound.CommandNotFound("/usr/share/command-not-found")
+            to_install = list()
+            for executable in [os.path.basename(f) for f in files]:
+                list_of_packages_and_components =  cnf.getPackages(executable)
+                if list_of_packages_and_components:
+                    (package, component) = list_of_packages_and_components[0]
+                    to_install.append(package)
+            if to_install:
+                yield self._install_package_names(xid, to_install, interaction, sender)
+                return
+            # FIXME: show a message here that the binaries were not
+            #        found instead of falling through to the misleading
+            #        other error message
+        except:
+            log.exception("command-not-found")
+
+        # FIXME: use a different error message
         header = _("Installing packages by files isn't supported")
         message = _("This method hasn't yet been implemented.")
         #FIXME: should provide some information about how to find apps
@@ -1028,7 +1047,7 @@
         header = _("Installing printer drivers on request isn't supported")
         message = _("Currently autodetection and installation of "
                     "missing printer drivers is not supported.")
-        #FIXME: should provide some information about how to get fonts
+        #FIXME: should provide some information about how to get printers
         dia = ErrorDialog(header, message)
         dia.run()
         dia.hide()