qtcreator-plugin-ubuntu

Merge lp:~mvo/qtcreator-plugin-ubuntu/lp1366791-deploy-finished into lp:qtcreator-plugin-ubuntu

  1. lp1366791-deploy-finished
  2. Merge into trunk
Proposed by Michael Vogt
Status: Merged
Approved by: Zoltan Balogh
Approved revision: 255
Merged at revision: 261
Proposed branch: lp:~mvo/qtcreator-plugin-ubuntu/lp1366791-deploy-finished
Merge into: lp:qtcreator-plugin-ubuntu
Diff against target: 16 lines (+4/-1)
1 file modified
src/ubuntu/ubuntupackagingwidget.cpp (+4/-1)
To merge this branch: bzr merge lp:~mvo/qtcreator-plugin-ubuntu/lp1366791-deploy-finished
Reviewer Review Type Date Requested Status
Benjamin Zeller Needs Fixing
PS Jenkins bot continuous-integration Approve
Zoltan Balogh Approve
Review via email: mp+233716@code.launchpad.net

Commit message

Another tiny branch. This makes it easier for the user to see when his/her click package is deployed to the device.

Description of the change

Another tiny branch. This makes it easier for the user to see when his/her click package is deployed to the device.

To post a comment you must log in.
Revision history for this message
Zoltan Balogh (bzoltan) wrote :

OK

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:255
http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-ci/414/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-utopic-amd64-ci/182
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-utopic-armhf-ci/182

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtcreator-plugin-ubuntu-ci/414/rebuild

review: Approve (continuous-integration)
Revision history for this message
Benjamin Zeller (zeller-benjamin) wrote :

Ok

review: Approve
Revision history for this message
Benjamin Zeller (zeller-benjamin) wrote :

The current implementation always inserts the new message as
the second last row instead of the last row when validating a click
package.

Please move the new code behind endReceiveData()

review: Needs Fixing
lp:~mvo/qtcreator-plugin-ubuntu/lp1366791-deploy-finished updated
256. By Michael Vogt

address review comments from zbenjamin

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/ubuntu/ubuntupackagingwidget.cpp'
2--- src/ubuntu/ubuntupackagingwidget.cpp 2014-08-20 07:38:07 +0000
3+++ src/ubuntu/ubuntupackagingwidget.cpp 2014-09-12 11:49:42 +0000
4@@ -185,8 +185,11 @@
5 }
6
7 void UbuntuPackagingWidget::onFinished(QString cmd, int code) {
8- Q_UNUSED(code);
9 m_inputParser->endRecieveData();
10+ if(code == 0)
11+ m_inputParser->emitTextItem(QLatin1String("Command finished successfully"),cmd,ClickRunChecksParser::NoIcon);
12+ else
13+ m_inputParser->emitTextItem(QLatin1String("Command failed"),cmd,ClickRunChecksParser::Error);
14 if (cmd == QString::fromLatin1(Constants::UBUNTUWIDGETS_ONFINISHED_SCRIPT_LOCAL_PACKAGE_INSTALLED).arg(Ubuntu::Constants::UBUNTU_SCRIPTPATH)) {
15 m_validationModel->clear();
16 QStringList lines = m_reply.trimmed().split(QLatin1String(Constants::LINEFEED));

Subscribers

People subscribed via source and target branches

to all changes: