Merge lp:~mvo/qtcreator-plugin-ubuntu/dialog-parents into lp:qtcreator-plugin-ubuntu

Proposed by Michael Vogt
Status: Merged
Approved by: Zoltan Balogh
Approved revision: 212
Merged at revision: 219
Proposed branch: lp:~mvo/qtcreator-plugin-ubuntu/dialog-parents
Merge into: lp:qtcreator-plugin-ubuntu
Diff against target: 59 lines (+5/-5)
4 files modified
src/ubuntu/ubuntuclickdialog.cpp (+1/-1)
src/ubuntu/ubuntudevicesmodel.cpp (+1/-1)
src/ubuntu/ubuntukitmanager.cpp (+2/-2)
src/ubuntu/ubuntumenu.cpp (+1/-1)
To merge this branch: bzr merge lp:~mvo/qtcreator-plugin-ubuntu/dialog-parents
Reviewer Review Type Date Requested Status
Zoltan Balogh Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+227677@code.launchpad.net

Commit message

Added missing dialog/message box parents.

Description of the change

This branch adds a bunch of missing dialog/message box parents. See bug #1346783 for the rational.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Zoltan Balogh (bzoltan) wrote :

OK

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/ubuntu/ubuntuclickdialog.cpp'
2--- src/ubuntu/ubuntuclickdialog.cpp 2014-06-16 15:40:12 +0000
3+++ src/ubuntu/ubuntuclickdialog.cpp 2014-07-22 07:44:31 +0000
4@@ -83,7 +83,7 @@
5
6 int UbuntuClickDialog::runClickModal(ProjectExplorer::ProcessParameters *params)
7 {
8- UbuntuClickDialog dlg;
9+ UbuntuClickDialog dlg(Core::ICore::mainWindow());
10 dlg.setParameters(params);
11 QMetaObject::invokeMethod(&dlg,"runClick",Qt::QueuedConnection);
12 dlg.exec();
13
14=== modified file 'src/ubuntu/ubuntudevicesmodel.cpp'
15--- src/ubuntu/ubuntudevicesmodel.cpp 2014-06-11 04:47:28 +0000
16+++ src/ubuntu/ubuntudevicesmodel.cpp 2014-07-22 07:44:31 +0000
17@@ -811,7 +811,7 @@
18 ProjectExplorer::DeviceManager::instance()->removeDevice(m_knownDevices[index]->device()->id());
19 else {
20 emit logMessage(QString::fromLatin1(Constants::UBUNTUDEVICESWIDGET_ONERROR).arg(QLatin1String(proc.readAll())));
21- QMessageBox::critical(0,tr("Could not delete emulator"),tr("The emulator %1 could not be deleted because of a error, check the logs for details").arg(name));
22+ QMessageBox::critical(Core::ICore::mainWindow(),tr("Could not delete emulator"),tr("The emulator %1 could not be deleted because of a error, check the logs for details").arg(name));
23 }
24
25 }
26
27=== modified file 'src/ubuntu/ubuntukitmanager.cpp'
28--- src/ubuntu/ubuntukitmanager.cpp 2014-06-16 15:40:12 +0000
29+++ src/ubuntu/ubuntukitmanager.cpp 2014-07-22 07:44:31 +0000
30@@ -68,7 +68,7 @@
31 {
32 ProjectExplorer::Abi requiredAbi = ClickToolChain::architectureNameToAbi(device->architecture());
33 if(requiredAbi.isNull()) {
34- QMessageBox::warning(0,
35+ QMessageBox::warning(Core::ICore::mainWindow(),
36 tr("Unknown device architecture"),
37 tr("Kit autocreation for %1 is not supported!")
38 .arg(device->architecture()));
39@@ -102,7 +102,7 @@
40 ClickToolChain* match = findCompatibleTc();
41 while(!match) {
42 //create target
43- int choice = QMessageBox::question(0,
44+ int choice = QMessageBox::question(Core::ICore::mainWindow(),
45 tr("No target available"),
46 tr("There is no compatible chroot available on your system, do you want to create it now?"));
47
48
49=== modified file 'src/ubuntu/ubuntumenu.cpp'
50--- src/ubuntu/ubuntumenu.cpp 2014-06-02 10:20:05 +0000
51+++ src/ubuntu/ubuntumenu.cpp 2014-07-22 07:44:31 +0000
52@@ -624,7 +624,7 @@
53 UbuntuDevice::ConstPtr device = UbuntuDeviceMode::instance()->device();
54 if (device) {
55 if( device->deviceState() != ProjectExplorer::IDevice::DeviceReadyToUse ) {
56- QMessageBox::warning(0,tr("Device not ready"),tr("The currently selected device is not ready, please select another one on the devices mode"));
57+ QMessageBox::warning(Core::ICore::mainWindow(),tr("Device not ready"),tr("The currently selected device is not ready, please select another one on the devices mode"));
58 return;
59 }
60

Subscribers

People subscribed via source and target branches

to all changes: