Merge lp:~mvo/pkgme/debian-rules-generic-override into lp:pkgme

[Michael Vogt]

This is a "is this the right approach?" branch.

Some packaging backends like pkgme-binary will need to be able to override calls to dh_*, one use
case would be something like this:

override_dh_shlibdeps:
 dh_shlibdeps -l$(CURDIR)/debian/$(PACKAGE_NAME)/opt/$(PACKAGE_NAME)/lib

This branch adds a GenericDebianRulesOverride InfoElement that is simply appended to the debian/rules
file and could implement a mechanism like this.

I'm happy to provide a more targeted approach if you feel that is more appropriate, something like
debian/rules to have "shlibdeps_search_path" to foo:bar:baz:
#if $shlibdeps_search_path
override_dh_shlibdeps:
 dh_shlibdeps -l${shlibdeps_search_path}
#end if

[Jonathan Lange (jml)]

See also https://code.launchpad.net/~jml/pkgme/rules-extra-targets/+merge/113951

[Michael Vogt (mvo)]

If we go down this route we should use the branch of jml, it has a better name, better tests and is doing the same. My mistake for not checking the previous MPs.

[Michael Vogt (mvo)]

Setting to rejected in favor of jmls version.

Unmerged revisions

119. By Michael Vogt on 2012-07-16

add new "generic_rules_override" to the debian/rules template to add stuff

=== modified file 'pkgme/info_elements.py'
--- pkgme/info_elements.py	2012-07-05 13:42:09 +0000
+++ pkgme/info_elements.py	2012-07-16 20:07:23 +0000
@@ -345,3 +345,9 @@
     a default copyright template that the user needs to fill in.
     """
 
+
+class GenericDebianRulesOverride(InfoElement):
+
+    name = 'generic_rules_override'
+    default = ''
+    description = """Additional dh_*_override for the debian/rules file"""

=== modified file 'pkgme/package_files.py'
--- pkgme/package_files.py	2012-07-16 17:50:39 +0000
+++ pkgme/package_files.py	2012-07-16 20:07:23 +0000
@@ -19,6 +19,7 @@
     Executable,
     ExtraFiles,
     ExtraFilesFromPaths,
+    GenericDebianRulesOverride,
     Homepage,
     Icon,
     License,
@@ -164,6 +165,7 @@
     elements = [
         Buildsystem,
         DebhelperAddons,
+        GenericDebianRulesOverride,
         ]
 
     filename = "rules"

=== modified file 'pkgme/templates/rules'
--- pkgme/templates/rules	2011-07-04 02:49:19 +0000
+++ pkgme/templates/rules	2012-07-16 20:07:23 +0000
@@ -9,3 +9,4 @@
 --with=${debhelper_addons} #slurp
 #end if
 
+${generic_rules_override}