Merge lp:~mvo/pkgme/add_option_include_binaries into lp:pkgme

Proposed by Michael Vogt
Status: Merged
Approved by: James Westby
Approved revision: 124
Merged at revision: 124
Proposed branch: lp:~mvo/pkgme/add_option_include_binaries
Merge into: lp:pkgme
Diff against target: 19 lines (+3/-1)
1 file modified
pkgme/debuild.py (+3/-1)
To merge this branch: bzr merge lp:~mvo/pkgme/add_option_include_binaries
Reviewer Review Type Date Requested Status
James Westby Approve
Review via email: mp+116877@code.launchpad.net

Commit message

Pass --include-binaries to debuild so that it doesn't fail if there are binary files

If there are icons in the debian directory then debuild will fail the build by default.

Description of the change

This adds a new option to build_source_package() to run dpkg-source with "--include-binaries" so that all binary files in the debian directory (like icons) are automatically added. We could also make this the default I guess given that we control what is written into debian/* and it was effectively what was done before by using the native format.

Note that this is fallout from the move from native to non-native, dpkg-source is then more strict about what can be in debian/* and what can't.

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :
Revision history for this message
James Westby (james-w) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'pkgme/debuild.py'
2--- pkgme/debuild.py 2012-07-20 19:24:04 +0000
3+++ pkgme/debuild.py 2012-07-26 14:37:19 +0000
4@@ -15,12 +15,14 @@
5 raise ValueError("Could not find changes filename")
6
7
8-def build_source_package(directory, sign=True):
9+def build_source_package(directory, sign=True, include_binaries=False):
10 """Build a source package using debuild"""
11 build_orig_tar_gz(directory)
12 cmd = ['debuild', '--no-lintian', '-S']
13 if not sign:
14 cmd.extend(['-uc', '-us'])
15+ if include_binaries:
16+ cmd.append("--source-option=--include-binaries")
17 output = run_subprocess(cmd, cwd=directory)
18 changes_file = find_changes_file(output)
19 return os.path.abspath(os.path.join(directory, changes_file))

Subscribers

People subscribed via source and target branches

to all changes: