Merge lp:~mvo/pkgme-devportal/i386-only-for-now into lp:pkgme-devportal
Proposed by
Michael Vogt
Status: | Merged |
---|---|
Approved by: | James Westby |
Approved revision: | 62 |
Merged at revision: | 62 |
Proposed branch: | lp:~mvo/pkgme-devportal/i386-only-for-now |
Merge into: | lp:pkgme-devportal |
Diff against target: |
125 lines (+31/-16) 4 files modified
devportalbinary/binary.py (+5/-2) devportalbinary/configuration.py (+15/-0) devportalbinary/database.py (+4/-14) devportalbinary/tests/test_binary.py (+7/-0) |
To merge this branch: | bzr merge lp:~mvo/pkgme-devportal/i386-only-for-now |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Westby | Needs Information | ||
Review via email: mp+115684@code.launchpad.net |
Commit message
Makes supported architectures configurable, and default to i386 for now.
Description of the change
This is a branch that make the architectures configurable and defaults to "i386" for now. It does affect the database as the previous default for the architectures included "all". AFAICT this should cause any regressions as in the database it was overriden.
Reference is bug #832128.
This will eventually lead to lp:~mvo/pkgme-devportal/more-architecture-when-scanning-binaries where the architecture configuration will actually mean that the database is filled with the additional architectures.
To post a comment you must log in.
Hi Michael,
I'm not really sure what "supported" architectures mean here, could you help me
out?
37 + # XXX: mvo: it seems we don't need "all" here as we are interessted
38 + # in binary symbols only?
I'm not sure what that means, but it sounds like something we should have an
answer for before we land this?
53 +ARCHITECTURES = load_configurat ion().options. architectures_ supported
Setting a module-level variable based on reading a config file is bad form,
because it will read the config file at import, which means it's hard
to write tests for example. Querying the config at use would be better.
Thanks,
James